Reference.__get__ might swallow exceptions

Bug #490914 reported by Jason Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Storm
New
Undecided
Unassigned

Bug Description

The following try/except block has a bit of an overactive except clause by the looks of it: http://bazaar.launchpad.net/~storm/storm/trunk/annotate/head%3A/storm/references.py#L189

For instance, this will swallow exceptions regarding __storm_table__ being missing.

Revision history for this message
James Henstridge (jamesh) wrote :

That bit of code is intended to allow assigning raw values to a reference (e.g. assigning an integer to a reference if the local key is an integer field). In these cases, the value won't have a __storm_table__ attribute, so swallowing the exception is appropriate.

Looking at the revision history, this feature was added to support the sqlobject compatibility layer (something we needed to help with porting Launchpad to run on Storm).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.