Storm

Session isolation level should only be set if configured

Bug #371806 reported by Drew Smathers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Storm
New
Undecided
Unassigned

Bug Description

This applies to oracle-support branch. Currently isolation level is always set on connection establishment and defaults to SERIALIZABLE. This is problematic because:

1. Client default conflicts with oracle default: READ COMMITTED
2. There is no way to prevent setting isolation level on session - default should be to do nothing

Revision history for this message
Drew Smathers (djfroofy) wrote :

See revision 278 in my branch for suggested patch: http://bazaar.launchpad.net/~djfroofy/storm/twisted-oracle/revision/278

Revision history for this message
Christopher Armstrong (radix) wrote :

Storm's transaction and caching semantics rely on a database which is providing SERIALIZABLE isolation. Setting it to something else (or allowing the default to be something else) can invalidate the basic recommended way that Storm is used, and should only be done by people who really know what they're doing. Therefore, I don't think this should be merged.

Revision history for this message
Drew Smathers (djfroofy) wrote :

Okay. I see now that this is also the case with other drivers (e.g. postgres). There are some other issues the patch reflects though which I think are still valid:

1. It should be possible to bypass setting isolation level (by setting isolation=none, for example)
2. The error message related to invalid isolation level (likely copied from postgres driver) incorrectly indicates "autocommit" as a possible option.

Please see my latest patch which sets isolation default back to serializable but also addresses (per revision 278) the above two issues:

http://bazaar.launchpad.net/~djfroofy/storm/twisted-oracle/revision/280

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.