Storm

storm-0.20 installs tests directory in site-packages

Bug #1199578 reported by Mike Gilbert
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Storm
Fix Released
High
Colin Watson
Storm 0.21

Bug Description

There is no reason to install the tests directory, and doing so can actually cause package manager file conflicts if multiple packages do so.

See patch for an easy solution.

Related branches

lp://staging/~cjwatson/storm/move-tests
Kristian Glass (community): Approve
Storm Developers: Pending requested
Diff: 522 lines (+65/-74)
32 files modified
MANIFEST.in (+1/-2)
NEWS (+2/-0)
setup.py (+1/-1)
storm/tests/__init__.py (+5/-4)
storm/tests/base.py (+1/-2)
storm/tests/cache.py (+1/-2)
storm/tests/database.py (+2/-3)
storm/tests/databases/base.py (+2/-3)
storm/tests/databases/postgres.py (+5/-5)
storm/tests/databases/sqlite.py (+2/-3)
storm/tests/event.py (+1/-2)
storm/tests/expr.py (+1/-2)
storm/tests/helper.py (+1/-1)
storm/tests/info.py (+1/-2)
storm/tests/infoheritance.txt (+2/-1)
storm/tests/properties.py (+7/-7)
storm/tests/schema/patch.py (+1/-1)
storm/tests/schema/schema.py (+1/-1)
storm/tests/schema/sharding.py (+1/-2)
storm/tests/sqlobject.py (+1/-2)
storm/tests/store/base.py (+2/-3)
storm/tests/store/postgres.py (+2/-3)
storm/tests/store/sqlite.py (+2/-3)
storm/tests/tracer.py (+2/-3)
storm/tests/tutorial.txt (+1/-1)
storm/tests/twisted/transact.py (+4/-4)
storm/tests/uri.py (+1/-2)
storm/tests/variables.py (+1/-2)
storm/tests/zope/adapters.py (+2/-2)
storm/tests/zope/testing.py (+6/-2)
storm/tests/zope/zstorm.py (+2/-2)
test (+1/-1)
Revision history for this message
Mike Gilbert (floppym) wrote :
Revision history for this message
Aurélien Bompard (abompard) wrote :

Actually you need to exclude the submodules of the tests module too, so the line should be:

packages=find_packages(exclude=['tests', 'tests.*'])

Revision history for this message
Colin Watson (cjwatson) wrote :

I agree that the current behaviour is annoying. Installing tests (in a better place!) is often handy so that you can do as-installed tests, though, and many Python packages do so. IMO the best thing to do here would instead be to move the tests to a storm.tests package so that they won't conflict with anything else.

Changed in storm:
assignee: nobody → Colin Watson (cjwatson)
importance: Undecided → High
status: New → In Progress
Colin Watson (cjwatson)
Changed in storm:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
Changed in storm:
milestone: none → 0.21
Colin Watson (cjwatson)
Changed in storm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.