SPF Engine

Allow logging of Postfix queue_id

Bug #1963816 reported by Wolfgang Karall-Ahlborn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SPF Engine
Fix Released
Wishlist
Unassigned
SPF Engine 3.0.0

Bug Description

Hello,

it would be nice (so this is clearly a wishlist bug) if there was a way to make policyd-spf add the Postfix queue_id to the log lines as other policyd's and milters do.

For example, when doing log analysis, it's difficult to match the python-spf line to the others, here's an excerpt:

policyd-spf[31728]: prepend Authentication-Results: host.example.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.208.42; helo=mail-ed1-f42.google.com; <email address hidden>; receiver=<UNKNOWN>)
postfix/smtpd[27540]: 5E4543EF9: client=mail-ed1-f42.google.com[209.85.208.42]
postfix/cleanup[32423]: 5E4543EF9: message-id=<email address hidden>
opendkim[11345]: 5E4543EF9: mail-ed1-f42.google.com [209.85.208.42] not internal
opendkim[11345]: 5E4543EF9: not authenticated
opendkim[11345]: 5E4543EF9: DKIM verification successful
opendkim[11345]: 5E4543EF9: s=20210112 d=gmail.com SSL
opendmarc[20059]: 5E4543EF9: gmail.com pass

If policyd-spf would log 5E4543EF9 here, too, it would be easy.

Cheers
Wolfgang

Revision history for this message
Scott Kitterman (kitterman) wrote :

Seems reasonable to have this for the policy server since it's only used by postfix.

Changed in spf-engine:
importance: Undecided → Wishlist
milestone: none → spf-engine-future
status: New → Triaged
Revision history for this message
Scott Kitterman (kitterman) wrote :

This will only work if you're using the policy post-queue (since, by definition there's no Queue ID before). It'll be included in v3.0.0.

Changed in spf-engine:
milestone: spf-engine-future → 3.0.0
status: Triaged → Fix Committed
Scott Kitterman (kitterman)
Changed in spf-engine:
status: Fix Committed → Fix Released
Revision history for this message
Wolfgang Karall-Ahlborn (biz+launchpad) wrote (last edit ):

Hi Scott,

thanks for the change in https://git.launchpad.net/spf-engine/commit/?id=1f1d7c67b8eed13c50866efa39509d514b2dce80

When I applied the patch on some test machine I noticed it is 'QueueID' in policyd_spf.py but 'Queue_ID' in policydspfsupp.py, I had to change the latter also to 'QueueID' to make it work.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.