Solum

Tech Debt: Add unit tests to alembic migration code

Bug #1274392 reported by Adrian Otto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Triaged
Low
Ravi Sankar Penta
Solum 2015.1.1 "liberty-2"

Bug Description

Our alembic migration code from https://review.openstack.org/68101 came from Oslo without unit tests. As soon as they are added to Oslo, we can add them to Solum. This bug was created to be sure we do not lose track of this as technical debt.

Tags: tech-debt
Angus Salkeld (asalkeld)
Changed in solum:
status: New → Triaged
Revision history for this message
Adrian Otto (aotto) wrote :

Is there a bug that tracks this on the Oslo side that we can link to this so we can periodically check if this has been done?

Adrian Otto (aotto)
Changed in solum:
importance: Low → Wishlist
Adrian Otto (aotto)
Changed in solum:
milestone: none → 2014.1.2
importance: Wishlist → Low
summary: - Add unit tests to alembic migration code
+ Debt: Add unit tests to alembic migration code
summary: - Debt: Add unit tests to alembic migration code
+ DEBT: Add unit tests to alembic migration code
Adrian Otto (aotto)
summary: - DEBT: Add unit tests to alembic migration code
+ Tech Debt: Add unit tests to alembic migration code
Adrian Otto (aotto)
tags: added: tech-debt
Revision history for this message
Pierre Padrixe (stannie) (pierre-padrixe) wrote :

test_migrations.py (the base class to write migration tests) is still not available for Alembic in oslo.
https://github.com/openstack/oslo-incubator/blob/master/openstack/common/db/sqlalchemy/test_migrations.py

So I guess we should use test_migration_base in its alembic modified version which is available in several projects: storyboard, sahara, ironic... (https://github.com/openstack-infra/storyboard/blob/master/storyboard/tests/db/migration/test_migrations_base.py) and once it's finally available in oslo we'll use the oslo version, but anyway the migration that will import the base class have to be written, so let's work on it.

I've some inputs coming from oslo IRC channel and oslo.db code within oslo-incubator is currently frozen as we are in the middle of oslo.db graduation. There is no bp available so I created https://blueprints.launchpad.net/oslo/+spec/db-test-migration-with-alembic

Adrian Otto (aotto)
Changed in solum:
milestone: 2014.1.2 → juno-1
Ravi Sankar Penta (ravips)
Changed in solum:
assignee: nobody → Ravi Sankar Penta (ravips)
Adrian Otto (aotto)
Changed in solum:
milestone: juno-1 → juno-2
Adrian Otto (aotto)
Changed in solum:
milestone: juno-2 → 2015.1.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.