Button on collaboration page needs tweaks

Bug #1745509 reported by Thomi Richards
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Software Center Agent
New
Undecided
Kit Randel

Bug Description

On the collaboration page for a snap, there's a button with the label "Share only with these people". However, the button has a white background, and the page has a white background, and the button border is a thing dotted grey line.... all this adds to making the button rather hard to see.

Additionally, the button is right-aligned with the form above it, while other forms on the same website (for example https://dashboard.snapcraft.io/snaps/<snapname>/revisions/<N>/feedback/ and https://dashboard.snapcraft.io/snaps/<snapname>/update/) have the submit buttons left-aligned with their forms.

I think we should revisit this design, ideally fixing both issues identified above.

See attached file for a screenshot showing both issues.

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :
Kit Randel (blr)
Changed in software-center-agent:
assignee: nobody → Kit Randel (blr)
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Specifying collaborators (why are they called “recipients”?) is the main thing you can do on this page, so I think this button should be a primary button, Vanilla green.

Vanilla’s form example <https://docs.vanillaframework.io/en/patterns/forms> shows that the main submit button for a form — in that case and this, the only button — goes on the right.

Both of those achieved by <button class="p-button--positive u-float-right">.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.