Erroneous rejection emails when submitting to click store

Thanks Robert. That is both confusing and excessive.

I'm not sure why, but there seem to be a bunch of uploads for Beru, four of which are now marked as "Automatically rejected".

So I'm assuming that when you uploaded the new package, *it* superseded four of the previous uploads (I can't see which state they were in previously - possibly awaiting review).

I don't know why we need the first email (awaiting moderation) - that sounds like an error in the case where you have automatic reviews with no moderation required.

I'd be keen to see the final email let you know that it was approved *and published* (since you had the checkbox to publish when approved).

Note to whoever gets to work on this: it'd be worth investigating why there are so many uploads for this app in the published state (when curl tells me only the latest, 1.1.2 is published - which is what we expect).

@Stephen - assigning to you only because I think you were planning on improving the emails soon? Feel free to unassign if that's not the case..

@michael this doesn't look like a bug related to the presentation of emails (html vrs plain text), so i'm removing myself as the assignee

Hi,

the main issue here is that

a) we send out an email with each state change (from New -> In Review
-> Rejected or Approved)
b) there were multiple uploads in review that got superseded by the
latest upload
c) all of these state changes happened in close succession to each other

We should probably fix this by only sending out emails about final
state (Rejected, Approved, Manual review pending)

On Tue, Sep 8, 2015 at 7:38 AM, Stephen Stewart
<email address hidden> wrote:
> @michael this doesn't look like a bug related to the presentation of
> emails (html vrs plain text), so i'm removing myself as the assignee
>
> ** Changed in: software-center-agent
> Assignee: Stephen Stewart (stephen-stewart) => (unassigned)
>
> --
> You received this bug notification because you are a member of Buy-
> something hackers, which is subscribed to Software Center Agent.
> https://bugs.launchpad.net/bugs/1493186
>
> Title:
> Erroneous rejection emails when submitting to click store
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/software-center-agent/+bug/1493186/+subscriptions

I think the issue is as Ricardo described, and I also think we should review the text from the transition emails.

On the other hand, if there were previous uploaded versions without a final review decision (which seems to be the case), since some time ago, on uploading a new one will automatically reject those previous uploads. This should have been a one-time thing only, being the first upload since that auto-reject previous got deployed. From now on, you shouldn't have more than one review pending version at a time.

Is it really necessary to send an email on a state transition?

Michael,

All of those packages listed in the screenshot are legitimate uploads, at least as far as I remember. Beru is approaching its two-year anniversary. In the 0.9 era, click creation and verification wasn't built into Qt Creator, so I ended up uploading some invalid click packages. Those four rejections are probably such files.

Ever since automated reviews started, I've been getting two emails with each upload -- the entering review and approval emails. This is a bit annoying (especially since they don't thread; see bug #1273830), but not confusing. It was the rejection emails that were the real problem here. Perhaps there's been a backend change, and it didn't realize it had already sent out rejection emails for the four rejected versions from years ago? If so, it's happened sometime since April.

I've attached the approval email as an attachment.

Matias,

I believe one of the early packages, uploaded in the manual review era, was superseded by a second version before it could be manually reviewed. Perhaps this was left in an odd state that triggered this? But I think there was only one, and I got four rejection emails.