the config is handled as function in a module
Bug #1586511 reported by
Leo Arias
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Snapcraft |
Fix Released
|
Medium
|
Leo Arias | ||
snapcraft (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
Yakkety |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
We can improve the config handling by including the save, load and get methods in an object.
This will simplify testing and is cleaner.
[Impact]
* No visual impact for users, the config file will have the same format and same path.
* This change improves the existing code, but also allows us to make an easier landing of the macaroons feature.
[Test Case]
* snapcraft login.
* build a snap.
* snapcraft upload the snap build.
* check that the snap is in the store.
* snapcraft logout.
* try snapcraft upload again.
* check that you get an error.
[Regression Potential]
* The existing features that use the config might fail: login, upload, logout.
description: | updated |
Changed in snapcraft: | |
milestone: | none → 2.10 |
Changed in snapcraft: | |
status: | In Progress → Fix Committed |
Changed in snapcraft (Ubuntu Xenial): | |
milestone: | none → xenial-updates |
Changed in snapcraft (Ubuntu Xenial): | |
status: | New → Fix Committed |
tags: | added: verification-needed |
Changed in snapcraft: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
https:/ /github. com/ubuntu- core/snapcraft/ pull/519