plugin methods return True
Bug #1481122 reported by
Leo Arias
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Snapcraft |
Fix Released
|
Medium
|
Sergio Schvezov | ||
Bug Description
It seems to be that on the plugin methods we are returning True to signal that everything went well.
I think it will be better to return nothing in case of success, or the artifact generated in case it's needed for other steps.
In case of error, we raise an exception.
Related branches
lp://staging/~sergiusens/snapcraft/1481122
- Leo Arias (community): Approve
-
Diff: 1075 lines (+146/-292)25 files modifiedsnapcraft/__init__.py (+3/-15)
snapcraft/cmds.py (+9/-5)
snapcraft/common.py (+1/-1)
snapcraft/lifecycle.py (+9/-36)
snapcraft/meta.py (+2/-5)
snapcraft/plugins/ant.py (+4/-8)
snapcraft/plugins/autotools.py (+6/-7)
snapcraft/plugins/catkin.py (+12/-34)
snapcraft/plugins/cmake.py (+3/-2)
snapcraft/plugins/copy.py (+4/-10)
snapcraft/plugins/go.py (+7/-9)
snapcraft/plugins/make.py (+2/-2)
snapcraft/plugins/maven.py (+4/-10)
snapcraft/plugins/python2.py (+11/-17)
snapcraft/plugins/python3.py (+11/-17)
snapcraft/plugins/qml.py (+2/-3)
snapcraft/plugins/roscore.py (+0/-1)
snapcraft/plugins/scons.py (+2/-3)
snapcraft/plugins/tar_content.py (+2/-2)
snapcraft/sources.py (+12/-18)
snapcraft/tests/test_base_plugin.py (+19/-41)
snapcraft/tests/test_copy_plugin.py (+7/-9)
snapcraft/tests/test_lifecycle.py (+8/-35)
snapcraft/tests/test_meta.py (+4/-0)
snapcraft/tests/test_sources.py (+2/-2)
| Changed in snapcraft: | |
| milestone: | none → 0.4 |
| Changed in snapcraft: | |
| assignee: | nobody → Sergio Schvezov (sergiusens) |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| Changed in snapcraft: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Leo Arias (elopio) wrote | #1 |
| Changed in snapcraft: | |
| status: | Fix Committed → Confirmed |
Revision history for this message
| Leo Arias (elopio) wrote | #2 |
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | #3 |
Revision history for this message
| Leo Arias (elopio) wrote | #4 |
| Changed in snapcraft: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | #5 |
| Changed in snapcraft: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
There are still a few places where a boolean is returned to notify success. Lets fix them for the next milestone.