HTTP_X_FORWARDED_PROTO is probably missing, resulting in bad origin address

Bug #2027624 reported by Lukas M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
skyline apiserver
New
Undecided
Unassigned

Bug Description

HTTP_X_FORWARDED_PROTO is probably missing or is not set correctly ( at least this is working for Horizon ), resulting in bad origin address when using Reverse Proxy and SSO.

Notice the redirect here: `https://openstack.example.com:5000/v3/auth/OS-FEDERATION/websso/openid?origin=https://skyline.example.com:None/api/openstack/skyline/api/v1/websso`, port is `None`

This can be breaking for Keystone, see the config snippet
```
[federation]
trusted_dashboard = https://skyline.example.com:None/api/openstack/skyline/api/v1/websso
```

Thanks

Revision history for this message
Shuai Qian (iauhsnaiq) wrote :

add port in the url
[federation]
trusted_dashboard = https://<openstack_ip>:9999/api/openstack/skyline/api/v1/websso

Revision history for this message
Lukas M (muhaha) wrote :

No, its happening before the Keystone authorization ( I can see in Keystone logs, that https://skyline.example.com:None/api/openstack/skyline/api/v1/websso is not added to trusted dashboards ), Nginx or Gunicorn does not handle reverse proxy a probably HTTP_X_FORWARDED_PROTO is not respected. Thats why its set to None, thus origin URL is generated like :None port. Just like Django does this https://code.djangoproject.com/ticket/27961#comment:3

Revision history for this message
conna (yangshaoxue) wrote (last edit ):

Please provide your skyline configuration file and skyline startup command (protocol and port number)

Please check the skyline image version, We fixed a similar bug: https://review.opendev.org/c/openstack/skyline-apiserver/+/879465

Revision history for this message
Lukas M (muhaha) wrote (last edit ):
Revision history for this message
Lukas M (muhaha) wrote (last edit ):
Revision history for this message
conna (yangshaoxue) wrote :

You can pull the latest image

Revision history for this message
Lukas M (muhaha) wrote :

I am using koll-ansible deployment.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.