[1.8rc1] Too many open files, after upgrade to rc1

13:42 < sabdfl> i did the upgrade
13:42 < sabdfl> and noticed that it was saying it had no boot image source
13:42 < sabdfl> so i went to settings
13:42 < sabdfl> there was the same usual text there
13:42 < sabdfl> i just pressed save
13:42 < sabdfl> and then it had the usual map of releases / architectures on the images page
13:42 < sabdfl> and downloaded images just fine

I think this can be fixed without the monkey patching with:
--- src/maasserver/bootresources.py 2015-06-02 08:46:21 +0000
+++ src/maasserver/bootresources.py 2015-06-27 01:17:41 +0000
@@ -666,6 +666,7 @@
                 cksummer.update(buf)
                 if len(buf) != self.read_size:
                     break
+ reader.close()

         if not cksummer.check():
             # Calculated sha256 hash from the data does not match, what

I'd like to see some test / result.
I did verify that simplestreams 'insert_item' does not call reader.close() for you.
the thing that is strange is that this reader has an 'open()' but you don't have to (and don't) close it.
so its kind of odd to expect you to close it.

Perhaps it looks more conventional like this:
--- src/maasserver/bootresources.py 2015-06-02 08:46:21 +0000
+++ src/maasserver/bootresources.py 2015-06-27 01:20:47 +0000
@@ -660,12 +660,14 @@
         # Write the contents into the database, while calculating the sha256
         # hash for the read data.
         with rfile.largefile.content.open('wb') as stream:
+ reader.open()
             while True:
                 buf = reader.read(self.read_size)
                 stream.write(buf)
                 cksummer.update(buf)
                 if len(buf) != self.read_size:
                     break
+ reader.close()

         if not cksummer.check():
             # Calculated sha256 hash from the data does not match, what

http://paste.ubuntu.com/11781385/