libzeitgeist vapi needs an update

Bug #739653 reported by Travis Glenn Hansen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sezen
New
Undecided
Unassigned
Unity
Fix Released
Medium
Mikkel Kamstrup Erlandsen
Unity Foundations
Fix Released
Medium
Mikkel Kamstrup Erlandsen
libzeitgeist
Fix Released
Medium
Mikkel Kamstrup Erlandsen
libzeitgeist (Ubuntu)
Fix Released
Undecided
Unassigned
unity (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

When bumping to the 3.x series sezen no longer compiles...

data-sink.c: In function ‘sezen_data_sink_load_events_co’:
data-sink.c:591:3: warning: format ‘%lld’ expects type ‘long long int’, but argument 5 has type ‘gint64’
data-sink.c: In function ‘sezen_data_sink_add_to_event_cache’:
data-sink.c:648:4: warning: passing argument 3 of ‘g_object_set_qdata_full’ makes pointer from integer without a cast
/usr/include/glib-2.0/gobject/gobject.h:487:6: note: expected ‘gpointer’ but argument is of type ‘GQuark’
data-sink.c: In function ‘sezen_data_sink_fill_category_bins’:
data-sink.c:708:15: warning: assignment makes integer from pointer without a cast
data-sink.c: In function ‘sezen_data_sink_search_co’:
data-sink.c:1014:3: warning: passing argument 6 of ‘g_regex_replace_eval’ from incompatible pointer type
/usr/include/glib-2.0/glib/gregex.h:430:8: note: expected ‘GRegexEvalCallback’ but argument is of type ‘gboolean (*)(struct GMatchInfo *, struct GString *, void *)’
data-sink.c: In function ‘sezen_data_sink_constructor’:
data-sink.c:1185:3: error: too many arguments to function ‘zeitgeist_log_install_monitor’
/usr/include/zeitgeist-1.0/zeitgeist-log.h:172:6: note: declared here
make[2]: *** [sezen-data-sink.o] Error 1
make[2]: *** Waiting for unfinished jobs....
utils.c: In function ‘sezen_list_wrapper_append’:
utils.c:191:2: warning: passing argument 2 of ‘g_list_append’ discards qualifiers from pointer target type
/usr/include/glib-2.0/glib/glist.h:53:8: note: expected ‘gpointer’ but argument is of type ‘gconstpointer’
utils.c: In function ‘sezen_list_wrapper_prepend’:
utils.c:197:2: warning: passing argument 2 of ‘g_list_prepend’ discards qualifiers from pointer target type
/usr/include/glib-2.0/glib/glist.h:55:8: note: expected ‘gpointer’ but argument is of type ‘gconstpointer’
pixbuf-cache.c: In function ‘sezen_pixbuf_cache_has_pixbuf_for_uri’:
pixbuf-cache.c:276:2: warning: passing argument 3 of ‘g_hash_table_lookup_extended’ from incompatible pointer type
/usr/include/glib-2.0/glib/ghash.h:81:10: note: expected ‘void **’ but argument is of type ‘const char **’
pixbuf-cache.c:276:2: warning: passing argument 4 of ‘g_hash_table_lookup_extended’ from incompatible pointer type
/usr/include/glib-2.0/glib/ghash.h:81:10: note: expected ‘void **’ but argument is of type ‘struct GdkPixbuf **’
pixbuf-cache.c: In function ‘sezen_pixbuf_cache_get_pixbuf_for_name_co’:
pixbuf-cache.c:735:3: warning: passing argument 3 of ‘g_hash_table_lookup_extended’ from incompatible pointer type
/usr/include/glib-2.0/glib/ghash.h:81:10: note: expected ‘void **’ but argument is of type ‘const char **’
pixbuf-cache.c:735:3: warning: passing argument 4 of ‘g_hash_table_lookup_extended’ from incompatible pointer type
/usr/include/glib-2.0/glib/ghash.h:81:10: note: expected ‘void **’ but argument is of type ‘struct GdkPixbuf **’
toolbar.c: In function ‘sezen_toolbar_set_model’:
toolbar.c:485:3: warning: passing argument 3 of ‘g_list_find_custom’ from incompatible pointer type
/usr/include/glib-2.0/glib/glist.h:88:8: note: expected ‘GCompareFunc’ but argument is of type ‘gint (*)(void *, void *)’
make[2]: Leaving directory `/var/tmp/portage/gnome-extra/sezen-0.1.0/work/sezen-0.1.0/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/gnome-extra/sezen-0.1.0/work/sezen-0.1.0'
make: *** [all] Error 2

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Try rebuilding a clean checkout of sezen, that's not what I get at all here... See attached build output - looks entirely unrelated to libzeitgeist.

Revision history for this message
Michal Hruby (mhr3) wrote :

@Mikkel: Yes sezen fails to build with latest Vala, but this bug is about broken monitor API in 0.3, so the vapi needs to be regenerated.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Will regen the vapi

Changed in libzeitgeist:
assignee: nobody → Mikkel Kamstrup Erlandsen (kamstrup)
importance: Undecided → Medium
status: New → Triaged
summary: - 3.x broke compilation of sezen
+ libzeitgeist vapi needs an update
Changed in unity-foundations:
assignee: nobody → Mikkel Kamstrup Erlandsen (kamstrup)
importance: Undecided → Medium
milestone: none → unity-3.6.8
status: New → Triaged
Changed in unity-foundations:
status: Triaged → Fix Committed
Changed in libzeitgeist:
status: Triaged → Fix Committed
Changed in unity:
assignee: nobody → Mikkel Kamstrup Erlandsen (kamstrup)
importance: Undecided → Medium
milestone: none → 3.6.8
status: New → Fix Committed
Changed in unity-foundations:
status: Fix Committed → Fix Released
Changed in unity:
status: Fix Committed → Fix Released
Changed in libzeitgeist:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libzeitgeist - 0.3.8-0ubuntu1

---------------
libzeitgeist (0.3.8-0ubuntu1) natty; urgency=low

  * New upstream release
    - ZeitgeistLog missing implementation of get_property for "connected"
      (LP: #734080)
    - libzeitgeist vapi needs an update (LP: #739653)
 -- Didier Roche <email address hidden> Wed, 23 Mar 2011 17:05:43 +0100

Changed in libzeitgeist (Ubuntu):
status: New → Fix Released
Revision history for this message
Travis Glenn Hansen (travisghansen) wrote :

With libzeitgeist-0.3.10 I'm still getting the same behavior originally reported :(

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

@Travis: Well, I *know* that the monitor api works from the vapi as I am using it in the Unity place daemons right now :-) Maybe it's a sezen issue that remains?

Revision history for this message
Michal Hruby (mhr3) wrote :

> Maybe it's a sezen issue that remains?

Sounds about right...

Revision history for this message
Travis Glenn Hansen (travisghansen) wrote :

I would guess so since it's the only app I have problems building against the newer libzeitgeist.

Changed in unity (Ubuntu):
status: New → Fix Released
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.