OpenStack Searchlight

Searchlight.service OPTS aren't included in sample conf file.

Bug #1523639 reported by Travis Tripp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Searchlight
Fix Released
Medium
Travis Tripp
OpenStack Searchlight mitaka-2 "m2"

Bug Description

Running the config generator as described in the dev env setup [0]
instructions does not include all the options for the service.
This adds those options.

[0] http://docs.openstack.org/developer/searchlight/dev-environment.html

None of the options here: https://github.com/openstack/searchlight/blob/master/searchlight/service.py#L30-L45

are in the generated oslo sample config file.

This is because they aren't included here:

https://github.com/openstack/searchlight/blob/master/searchlight/opts.py

This should add the following: ('service', service.OPTS),

Please note there is another bug that actually is somewhat related: https://bugs.launchpad.net/searchlight/+bug/1493975 The configuration between API service and Listener service is intermingled.

See original description
Travis Tripp (travis-tripp)
description: updated
Changed in searchlight:
assignee: nobody → Travis Tripp (travis-tripp)
Revision history for this message
Travis Tripp (travis-tripp) wrote :

https://review.openstack.org/#/c/254354/

Changed in searchlight:
status: New → In Progress
importance: Undecided → Medium
milestone: none → mitaka-2
Revision history for this message
Liyingjun (liyingjun) wrote :

https://review.openstack.org/#/c/253973/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to searchlight (master)

Reviewed: https://review.openstack.org/253973
Committed: https://git.openstack.org/cgit/openstack/searchlight/commit/?id=d35dc3676a64d106f3eeacdf628449b869482785
Submitter: Jenkins
Branch: master

commit d35dc3676a64d106f3eeacdf628449b869482785
Author: liyingjun <email address hidden>
Date: Sun Nov 29 23:54:21 2015 +0800

    Set listener workers according to config

    Currently, the get_workers method always return 1, so config
    listener_workers will never work as expected. This patch adds
    the ability to specify number of workers for listener service.
    The default is equal to the number of CPUs available.
    Also, register searchlight.service.OPTS to group 'listener' in
    searchlight.listener.
    Remove not used options 'host' and 'http_timeout'.

    Change-Id: Ifc39d5eaab1a7b0239631aa1b2b6e0af3a07f0c9
    Closes-bug: #1522737
    Closes-bug: #1523639

Changed in searchlight:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on searchlight (master)

Change abandoned by Travis Tripp (<email address hidden>) on branch: master
Review: https://review.openstack.org/254354
Reason: This patch is superseded by these:

https://review.openstack.org/#/c/253973/7
https://review.openstack.org/#/c/253981/7

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.