licensing information incorrect in some source files
Bug #1653413 reported by
Fabio Valentini
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| AppCenter |
New
|
Undecided
|
Unassigned | ||
| Camera |
New
|
Undecided
|
Unassigned | ||
| Files |
Fix Released
|
High
|
Jeremy Wootten | ||
| Granite |
New
|
Undecided
|
Unassigned | ||
| Greeter |
New
|
Undecided
|
Unassigned | ||
| Maya |
New
|
Undecided
|
Unassigned | ||
| Scratch |
New
|
Undecided
|
Unassigned | ||
| Slingshot |
New
|
Undecided
|
Unassigned | ||
| Switchboard |
New
|
Undecided
|
Unassigned | ||
| Switchboard Accessibility Plug |
New
|
Undecided
|
Unassigned | ||
| Switchboard Applications Plug |
Fix Released
|
High
|
Danielle Foré | ||
| Switchboard Desktop Plug |
Confirmed
|
High
|
Unassigned | ||
| Switchboard Display Plug |
New
|
Undecided
|
Unassigned | ||
| Switchboard Mouse & Touchpad Plug |
New
|
Undecided
|
Unassigned | ||
| Switchboard Notifications Plug |
New
|
Undecided
|
Unassigned | ||
| Switchboard Parental Controls Plug |
New
|
Undecided
|
Unassigned | ||
| Switchboard Power Plug |
New
|
Undecided
|
Unassigned | ||
| Switchboard Printers Plug |
New
|
Undecided
|
Unassigned | ||
| Switchboard Security & Privacy Plug |
Fix Released
|
High
|
Fernando Alvarenga | ||
| Switchboard Sharing Plug |
New
|
Undecided
|
Unassigned | ||
| Wingpanel |
New
|
Undecided
|
Unassigned | ||
| Wingpanel Ayatana Indicator |
New
|
Undecided
|
Unassigned | ||
| Wingpanel Date & Time Indicator |
New
|
Undecided
|
Unassigned | ||
| Wingpanel Power Indicator |
New
|
Undecided
|
Unassigned | ||
| Wingpanel Session Indicator |
Fix Committed
|
High
|
Danielle Foré | ||
| Wingpanel Sound Indicator |
Fix Released
|
High
|
Danielle Foré | ||
Bug Description
For Example (maya-calendar):
Running licensecheck on the maya-calendar sources reports that some of the files which include licensing information include the wrong FSF address.
$ licensecheck -r . | awk -F ": " '{ print $2 }' | sort | uniq -c | sort -gr
163 *No copyright* UNKNOWN
101 UNKNOWN
38 GPL (v3 or later)
6 LGPL (v2 or later) (with incorrect FSF address)
4 *No copyright* GENERATED FILE
4 BSD (2 clause)
3 *No copyright* GPL (v3 or later)
2 LGPL (v2.1 or later)
The affected files are:
$ licensecheck -r . | grep incorrect
./core/
./core/
./core/
./core/
./plugins/
./plugins/
Package checkers / linters (for example the compulsory fedora one - rpmlint) complain very verbosely about this.
Related branches
lp://staging/~elementary-pantheon/switchboard-plug-applications/licensecheck
- Neal Gompa (community): Approve
- Cody Garver (community): Approve
-
Diff: 726 lines (+395/-51)18 files modifiedCOPYING (+344/-0)
debian/copyright (+3/-3)
src/Defaults/DefaultPlug.vala (+3/-3)
src/Defaults/Utils.vala (+3/-3)
src/Plug.vala (+3/-3)
src/Startup/Backend/DesktopFileEnumerator.vala (+3/-3)
src/Startup/Backend/KeyFile.vala (+3/-3)
src/Startup/Backend/KeyFileFactory.vala (+3/-3)
src/Startup/Backend/Monitor.vala (+3/-3)
src/Startup/Controller.vala (+3/-3)
src/Startup/Entities/AppInfo.vala (+3/-3)
src/Startup/Startup.vala (+3/-3)
src/Startup/Utils.vala (+3/-3)
src/Startup/Widgets/AppChooser.vala (+3/-3)
src/Startup/Widgets/AppChooserRow.vala (+3/-3)
src/Startup/Widgets/AppRow.vala (+3/-3)
src/Startup/Widgets/List.vala (+3/-3)
src/Startup/Widgets/Scrolled.vala (+3/-3)
lp://staging/~elementary-pantheon/wingpanel-indicator-session/licensecheck
- WingPanel Devs: Pending requested
-
Diff: 1101 lines (+306/-637)7 files modifiedCOPYING (+287/-618)
src/Indicator.vala (+3/-3)
src/Services/DbusInterfaces.vala (+4/-4)
src/Services/UserManager.vala (+3/-3)
src/Widgets/EndSessionDialog.vala (+2/-2)
src/Widgets/UserBox.vala (+3/-3)
src/Widgets/UserListBox.vala (+4/-4)
lp://staging/~elementary-pantheon/wingpanel-indicator-sound/licensecheck
- Neal Gompa (community): Approve (license header text check)
- David Hewitt: Approve
- WingPanel Devs: Pending requested
-
Diff: 994 lines (+786/-94)10 files modifiedCOPYING (+679/-0)
src/Indicator.vala (+16/-16)
src/Services/MprisClient.vala (+16/-10)
src/Services/Settings.vala (+16/-16)
src/Services/Volume-control.vala (+3/-4)
src/Widgets/DisplayWidget.vala (+3/-5)
src/Widgets/MaxWidthLabel.vala (+17/-17)
src/Widgets/MprisGui.vala (+10/-5)
src/Widgets/MprisWidget.vala (+10/-5)
src/Widgets/Scale.vala (+16/-16)
lp://staging/~jeremywootten/pantheon-files/fix-1653412-license-faults
- elementary Apps team: Pending requested
-
Diff: 2195 lines (+392/-247)110 files modifiedAUTHORS (+2/-0)
HACKING (+2/-0)
INSTALL (+2/-0)
README (+2/-0)
cmake/README (+2/-0)
filechooser-module/FileChooserDialog.vala (+2/-2)
filechooser-module/Plugin.vala (+2/-2)
libcore/AbstractSidebar.vala (+1/-1)
libcore/AbstractSlot.vala (+1/-1)
libcore/Bookmark.vala (+1/-1)
libcore/BookmarkList.vala (+1/-1)
libcore/DndHandler.vala (+1/-1)
libcore/Enums.vala (+2/-2)
libcore/FileUtils.vala (+1/-1)
libcore/Plugin.vala (+18/-0)
libcore/PluginManager.vala (+1/-1)
libcore/SoundManager.vala (+2/-2)
libcore/eel-accessibility.c (+3/-3)
libcore/eel-accessibility.h (+3/-3)
libcore/eel-debug.c (+3/-3)
libcore/eel-debug.h (+3/-3)
libcore/eel-fcts.c (+3/-3)
libcore/eel-fcts.h (+3/-3)
libcore/eel-gdk-pixbuf-extensions.c (+3/-3)
libcore/eel-gdk-pixbuf-extensions.h (+3/-3)
libcore/eel-gio-extensions.c (+1/-1)
libcore/eel-gio-extensions.h (+1/-1)
libcore/eel-glib-extensions.c (+3/-3)
libcore/eel-glib-extensions.h (+1/-1)
libcore/eel-gtk-extensions.c (+3/-3)
libcore/eel-gtk-extensions.h (+3/-3)
libcore/eel-i18n.c (+3/-3)
libcore/eel-i18n.h (+3/-3)
libcore/eel-pango-extensions.c (+2/-2)
libcore/eel-pango-extensions.h (+2/-2)
libcore/eel-stock-dialogs.c (+3/-3)
libcore/eel-stock-dialogs.h (+3/-3)
libcore/eel-string.c (+3/-3)
libcore/eel-string.h (+3/-3)
libcore/eel-ui.c (+3/-3)
libcore/eel-ui.h (+3/-3)
libcore/eel-vfs-extensions.c (+3/-3)
libcore/eel-vfs-extensions.h (+3/-3)
libcore/fm-list-model.c (+3/-3)
libcore/fm-list-model.h (+3/-3)
libcore/gof-callwhenready.vala (+1/-1)
libcore/gof-directory-async.vala (+1/-1)
libcore/gof-file.c (+1/-1)
libcore/gof-file.h (+4/-3)
libcore/gof-preferences.vala (+1/-1)
libcore/marlin-exec.c (+1/-1)
libcore/marlin-exec.h (+1/-1)
libcore/marlin-file-changes-queue.c (+3/-3)
libcore/marlin-file-changes-queue.h (+3/-3)
libcore/marlin-file-conflict-dialog.c (+3/-3)
libcore/marlin-file-conflict-dialog.h (+3/-3)
libcore/marlin-file-operations.c (+4/-4)
libcore/marlin-file-operations.h (+4/-4)
libcore/marlin-file-utilities.c (+3/-3)
libcore/marlin-file-utilities.h (+3/-3)
libcore/marlin-icon-info.c (+3/-3)
libcore/marlin-icon-info.h (+3/-3)
libcore/marlin-icons.h (+18/-0)
libcore/marlin-intl.h (+18/-0)
libcore/marlin-progress-info-manager.c (+3/-3)
libcore/marlin-progress-info-manager.h (+3/-3)
libcore/marlin-progress-info.c (+3/-3)
libcore/marlin-progress-info.h (+3/-3)
libcore/marlin-trash-monitor.c (+3/-3)
libcore/marlin-trash-monitor.h (+3/-3)
libcore/marlin-undostack-manager.c (+3/-3)
libcore/marlin-undostack-manager.h (+3/-3)
libcore/tests/GOFDirectoryAsyncTests/marlincore-tests-file.c (+3/-3)
libcore/tests/GOFDirectoryAsyncTests/marlincore-tests-file.h (+3/-3)
libcore/tests/GOFDirectoryAsyncTests/tests.c (+3/-3)
libcore/tests/GOFFileTests/marlincore-tests-gof.c (+3/-3)
libcore/tests/GOFFileTests/marlincore-tests-gof.h (+3/-3)
libcore/tests/GOFFileTests/tests.c (+3/-3)
libcore/tests/MarlinIconInfoTests/marlincore-tests-icon-info.c (+4/-4)
libcore/tests/MarlinIconInfoTests/marlincore-tests-icon-info.h (+3/-3)
libcore/tests/MarlinIconInfoTests/tests.c (+3/-3)
libcore/tests/UtilTests/UtilTests.vala (+3/-3)
libwidgets/Animations/Animations.vala (+2/-2)
libwidgets/Chrome/BasicBreadcrumbsEntry.vala (+2/-2)
libwidgets/Chrome/BasicLocationBar.vala (+2/-2)
libwidgets/Chrome/BreadcrumbElement.vala (+3/-3)
libwidgets/Chrome/BreadcrumbIconList.vala (+17/-0)
libwidgets/Welcome.vala (+2/-2)
pantheon-files-daemon/client.vala (+16/-0)
pantheon-files-daemon/miner.vala (+16/-0)
plugins/network-places/plugin.vala (+13/-13)
src/ClipboardManager.vala (+2/-2)
src/DesktopLauncher.vala (+15/-0)
src/Dialogs/AbstractPropertiesDialog.vala (+3/-3)
src/Dialogs/ChooseAppDialog.vala (+2/-2)
src/Dialogs/PropertiesWindow.vala (+2/-2)
src/Dialogs/VolumePropertiesWindow.vala (+2/-2)
src/IconRenderer.vala (+2/-2)
src/Thumbnailer.vala (+2/-2)
src/Utils/Permissions.vala (+2/-2)
src/View/DirectoryNotFound.vala (+2/-2)
src/View/ViewContainer.vala (+2/-2)
src/View/Widgets/BreadcrumbsEntry.vala (+2/-2)
src/View/Widgets/DiskRenderer.vala (+2/-2)
src/View/Widgets/Label.vala (+2/-2)
src/View/Widgets/LocationBar.vala (+2/-2)
src/View/Widgets/PermissionButton.vala (+3/-3)
src/marlin-connect-server-dialog.c (+2/-2)
src/marlin-connect-server-dialog.h (+2/-2)
src/marlin-global-preferences.h (+16/-0)
lp://staging/~ferbarcelona10/switchboard-plug-security-privacy/license-check
- David Hewitt: Approve
- Danielle Foré: Approve
-
Diff: 343 lines (+94/-54)11 files modifiedsrc/BlackList.vala (+5/-5)
src/Plug.vala (+5/-5)
src/UFWHelpers.vala (+8/-8)
src/Views/FirewallPanel.vala (+7/-7)
src/Views/LocationPanel.vala (+3/-3)
src/Views/LockPanel.vala (+7/-7)
src/Views/TrackPanel.vala (+7/-7)
src/Widgets/ClearUsagePopover.vala (+6/-6)
src/Widgets/ServiceItem.vala (+20/-0)
src/Widgets/ServiceList.vala (+20/-0)
src/ZGUtilities.vala (+6/-6)
| description: | updated |
Revision history for this message
| Danielle Foré (danrabbit) wrote | #1 |
| no longer affects: | pantheon-photos |
| tags: | added: cross-distro |
| tags: | added: fedora |
| Changed in switchboard-plug-applications: | |
| assignee: | nobody → Daniel Fore (danrabbit) |
| milestone: | none → juno-beta1 |
| status: | New → In Progress |
| Changed in switchboard-plug-applications: | |
| status: | In Progress → Fix Committed |
| Changed in switchboard-plug-applications: | |
| importance: | Undecided → High |
| Changed in wingpanel-indicator-session: | |
| assignee: | nobody → Daniel Fore (danrabbit) |
| importance: | Undecided → High |
| status: | New → In Progress |
| Changed in wingpanel-indicator-sound: | |
| assignee: | nobody → Daniel Fore (danrabbit) |
| importance: | Undecided → High |
| milestone: | none → juno-beta1 |
| status: | New → In Progress |
| Changed in wingpanel-indicator-session: | |
| status: | In Progress → Fix Committed |
| Changed in wingpanel-indicator-sound: | |
| status: | In Progress → Fix Committed |
| Changed in switchboard-plug-pantheon-shell: | |
| importance: | Undecided → High |
| status: | New → Confirmed |
| Changed in pantheon-files: | |
| assignee: | nobody → Jeremy Wootten (jeremywootten) |
| importance: | Undecided → Low |
| milestone: | none → juno-beta1 |
| status: | New → In Progress |
| Changed in pantheon-files: | |
| importance: | Low → High |
| status: | In Progress → Fix Committed |
| Changed in switchboard-plug-applications: | |
| status: | Fix Committed → Fix Released |
| Changed in wingpanel-indicator-session: | |
| milestone: | none → juno-beta1 |
| Changed in pantheon-files: | |
| milestone: | juno-beta1 → 0.3.2 |
| status: | Fix Committed → Fix Released |
| Changed in switchboard-plug-security-privacy: | |
| importance: | Undecided → High |
| milestone: | none → juno-beta1 |
| status: | New → Confirmed |
| assignee: | nobody → Fernando Alvarenga (ferbarcelona10) |
| Changed in switchboard-plug-security-privacy: | |
| status: | Confirmed → Fix Committed |
| Changed in wingpanel-indicator-sound: | |
| status: | Fix Committed → Fix Released |
| Changed in switchboard-plug-security-privacy: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Zisu Andrei (matzipan) wrote | #2 |
Revision history for this message
| Zisu Andrei (matzipan) wrote | #3 |
Revision history for this message
| Zisu Andrei (matzipan) wrote | #4 |
Revision history for this message
| Zisu Andrei (matzipan) wrote | #5 |
Revision history for this message
| Zisu Andrei (matzipan) wrote | #6 |
Revision history for this message
| Zisu Andrei (matzipan) wrote | #7 |
To post a comment you must log in.
Unmarking Photos since it has a more specific report here: https:/