Scratch

Contractor plugin does not show up in extensions list

Bug #1171397 reported by Pim Vullers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Scratch
Fix Released
Medium
Mario Guerriero
Scratch 2.0 "Inferno"

Bug Description

When starting scratch and selecting the 'New file' option, it takes a while (approx 10 sec.) before the new file is available. In the mean time scratch seems to 'hang'.

The same happens when opening an existing file from the command line or file manager. The window decoration appears, but there are no contents (i.e. the content of the window is like screenshot of the viewport, the apps/background behind the window.

When opening a file using the 'open' option from the welcome screen the 'open/OK' button from the file chooser remains pressed and again gives a frozen impression until the file has been opened.

So it seems something is blocking the rendering and the rest of the application when opening a file.

This is on Gentoo Linux with scratch from trunk. Let me know if you need additional information.

Related branches

lp://staging/~mefrio-g/scratch/rework
Danielle Foré: Approve
Sergey "Shnatsel" Davidoff (community): Needs Fixing
Cody Garver: Pending requested
Diff: 38298 lines (+3995/-32753) (has conflicts)
137 files modified
CMakeLists.txt (+12/-14)
README (+1/-1)
org.pantheon.scratch.gschema.xml (+0/-179)
plugins/CMakeLists.txt (+3/-3)
plugins/browser-preview/CMakeLists.txt (+0/-1)
plugins/browser-preview/browser-preview.vala (+64/-64)
plugins/contractor/CMakeLists.txt (+0/-1)
plugins/contractor/contractor.plugin (+1/-1)
plugins/contractor/contractor.vala (+59/-38)
plugins/devhelp/CMakeLists.txt (+0/-43)
plugins/devhelp/devhelp.plugin (+0/-10)
plugins/devhelp/devhelp.vala (+0/-97)
plugins/filemanager/CMakeLists.txt (+16/-17)
plugins/filemanager/filemanager.vala (+44/-12)
plugins/filemanager/marlincore.vala (+43/-37)
plugins/open-with/CMakeLists.txt (+23/-0)
plugins/open-with/open-with.plugin (+9/-0)
plugins/open-with/open-with.vala (+81/-0)
plugins/pastebin/CMakeLists.txt (+15/-16)
plugins/pastebin/pastebin.plugin (+1/-1)
plugins/pastebin/pastebin.vala (+15/-21)
plugins/pastebin/pastebin_dialog.vala (+25/-60)
plugins/spell-check/CMakeLists.txt (+0/-38)
plugins/spell-check/spell-check.plugin (+0/-10)
plugins/spell-check/spell-check.vala (+0/-64)
plugins/spell/CMakeLists.txt (+37/-0)
plugins/spell/spell.plugin (+10/-0)
plugins/spell/spell.vala (+59/-0)
plugins/strip-trailing-save/CMakeLists.txt (+0/-1)
plugins/strip-trailing-save/strip-trailing-save.vala (+9/-15)
plugins/terminal/CMakeLists.txt (+0/-1)
plugins/terminal/terminal.vala (+61/-52)
po/CMakeLists.txt (+2/-2)
po/am.po (+0/-517)
po/ar.po (+0/-519)
po/bg.po (+0/-517)
po/ca.po (+0/-525)
po/cs.po (+0/-524)
po/da.po (+0/-519)
po/de.po (+0/-518)
po/en_AU.po (+0/-519)
po/en_CA.po (+0/-525)
po/en_GB.po (+0/-525)
po/eo.po (+0/-518)
po/es.po (+0/-529)
po/eu.po (+0/-525)
po/fa.po (+0/-525)
po/fi.po (+0/-519)
po/fr.po (+0/-533)
po/gl.po (+0/-525)
po/hi.po (+0/-519)
po/hr.po (+0/-519)
po/hu.po (+0/-525)
po/id.po (+0/-524)
po/it.po (+0/-527)
po/ja.po (+0/-517)
po/jv.po (+0/-517)
po/km.po (+0/-523)
po/ko.po (+0/-517)
po/lt.po (+0/-517)
po/lv.po (+0/-520)
po/ml.po (+0/-517)
po/ms.po (+0/-523)
po/nb.po (+0/-525)
po/ne.po (+0/-518)
po/nl.po (+0/-524)
po/nn.po (+0/-517)
po/oc.po (+0/-517)
po/pl.po (+0/-525)
po/pt.po (+0/-511)
po/pt_BR.po (+0/-526)
po/ro.po (+0/-525)
po/ru.po (+0/-524)
po/rue.po (+0/-517)
po/scratch-text-editor.pot (+471/-0)
po/scratch.pot (+0/-509)
po/sk.po (+0/-517)
po/sl.po (+0/-517)
po/sr.po (+0/-520)
po/th.po (+0/-517)
po/tr.po (+0/-520)
po/uk.po (+0/-518)
po/vi.po (+0/-523)
po/zh_CN.po (+0/-523)
po/zh_TW.po (+0/-523)
schemas/CMakeLists.txt (+2/-0)
schemas/org.pantheon.scratch.gschema.xml (+179/-0)
scratchcore/CMakeLists.txt (+0/-82)
scratchcore/FileHandler.vala (+0/-141)
scratchcore/PluginManager.vala (+0/-322)
scratchcore/SearchManager.vala (+0/-525)
scratchcore/Settings.vala (+0/-90)
scratchcore/SourceView.vala (+0/-233)
scratchcore/TemplateManager.vala (+0/-207)
scratchcore/core-tests/CMakeLists.txt (+0/-33)
scratchcore/core-tests/main.vala (+0/-106)
scratchcore/main.vala (+0/-9)
scratchcore/scratchcore.pc.cmake (+0/-12)
src/CMakeLists.txt (+42/-22)
src/Dialogs/PreferencesDialog.vala (+55/-44)
src/Dialogs/SaveDialog.vala (+0/-114)
src/Dialogs/SaveOnCloseDialog.vala (+0/-52)
src/Dialogs/WarnDialog.vala (+0/-92)
src/MainWindow.vala (+393/-876)
src/Scratch.vala (+72/-152)
src/Services/Document.vala (+458/-764)
src/Services/Encoding.vala (+2/-2)
src/Services/FileHandler.vala (+128/-0)
src/Services/PluginManager.vala (+182/-0)
src/Services/Settings.vala (+90/-0)
src/Services/TemplateManager.vala (+236/-0)
src/Services/ZeitgeistLogger.vala (+2/-2)
src/Utils.vala (+49/-0)
src/Widgets/ComboSyntax.vala (+0/-65)
src/Widgets/DocumentView.vala (+154/-0)
src/Widgets/Notebook.vala (+0/-219)
src/Widgets/NotificationBar.vala (+0/-120)
src/Widgets/SearchManager.vala (+375/-0)
src/Widgets/ShareMenu.vala (+0/-63)
src/Widgets/SourceView.vala (+237/-0)
src/Widgets/SplitView.vala (+140/-115)
src/Widgets/StatusBar.vala (+0/-47)
src/Widgets/Tab.vala (+0/-269)
src/Widgets/TabLabel.vala (+0/-157)
src/Widgets/ToolBar.vala (+58/-162)
src/scratch-ui.xml (+27/-0)
src/scratch.deps (+0/-7)
src/scratch.pc.cmake (+0/-12)
src/scratchcore.deps (+7/-0)
src/scratchcore.pc.cmake (+12/-0)
tests/template_test/README (+0/-1)
vapi/gtkspell-3.0.deps (+0/-1)
vapi/gtkspell-3.0.vapi (+0/-24)
vapi/libdevhelp-3.0.deps (+0/-2)
vapi/libdevhelp-3.0.vapi (+0/-213)
vapi/libpeas-gtk-1.0.vapi (+34/-0)
vapi/peas-gtk.vapi (+0/-34)
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

I can't reproduce it. What GTk+ version are you using? Could you try with the following branch: https://code.launchpad.net/~mefrio-g/scratch/rework

Changed in scratch:
status: New → Confirmed
status: Confirmed → New
Revision history for this message
Pim Vullers (pimvullers) wrote :

I tried to build this branch but get the following error when trying to install:

make -j3 install
[ 2%] messages.”
[ 51%] [ 51%] Built target scratchcore
Built target i18n
[100%] Built target scratch-text-editor
Install the project...
-- Install configuration: "Gentoo"
-- Installing: /tmp/portage/app-editors/scratch-9999-r1/image/usr/share/applications/scratch-text-editor.desktop
-- Installing: /tmp/portage/app-editors/scratch-9999-r1/image/usr/bin/scratch-text-editor
-- Removed runtime path from "/tmp/portage/app-editors/scratch-9999-r1/image//usr/bin/scratch-text-editor"
-- Installing: /tmp/portage/app-editors/scratch-9999-r1/image/usr/share/scratch/scratch-ui.xml
CMake Error at src/cmake_install.cmake:66 (FILE):
  file INSTALL cannot find
  "/tmp/portage/app-editors/scratch-9999-r1/work/scratch-9999_build/src/scratchcore.pc".
Call Stack (most recent call first):
  cmake_install.cmake:41 (INCLUDE)

make: *** [install] Error 1

This seems to be caused by the following CMakeLists.txt line (which renames it to scratch.pc):

configure_file (${CMAKE_SOURCE_DIR}/src/scratchcore.pc.cmake ${CMAKE_BINARY_DIR}/src/scratch.pc)

while src/CMakeLists.txt refers to the file as scratchcore.pc for the install command.

Revision history for this message
Pim Vullers (pimvullers) wrote :

I'm using Gtk+ 3.4.4 and Glib 2.34.3 and compiled with Vala 0.20.1.

Revision history for this message
Pim Vullers (pimvullers) wrote :

Similar install issues are caused by scratch.vapi, scratch.deps and scratch.h.

Also the generated .so file has the strange name scratchcore.so.scratchcore (which does not get installed).

Revision history for this message
Pim Vullers (pimvullers) wrote :

For this last issue VERSION ${LIBNAME} should be replaced with VERSION ${VERSION} in

set_target_properties (${LIBNAME} PROPERTIES
    VERSION ${LIBNAME}
    SOVERSION ${SOVERSION}
)

Furthermore an install target should be added to install this library like:

install (TARGETS ${LIBNAME} LIBRARY DESTINATION lib)

Revision history for this message
Pim Vullers (pimvullers) wrote :

After quickfixing the abovementioned problems I managed to install the rework branch and run it. This reworked version does not exhibit the delay when opening new or existing files. (It even seems to be faster then before.)

Cody Garver (codygarver)
Changed in scratch:
status: New → In Progress
importance: Undecided → Medium
Mario Guerriero (mefrio-g)
Changed in scratch:
assignee: nobody → Mario Guerriero (mefrio-g)
milestone: none → 1.2
Revision history for this message
Pim Vullers (pimvullers) wrote :

FYI. I just build the 1.1.1 release, and then it works just fine. So the issue is not (directly) caused by any of the libraries used on my system. So it is caused by some change introduced in trunk after 1.1.1, which has been dropped in the 1.2 rework branch.

Revision history for this message
Pim Vullers (pimvullers) wrote :

Some further investigation showed that this delay is caused by the contractor plugin. To be more precise by contractor (which does not work correctly on my system).

Changed in scratch:
status: In Progress → Invalid
Revision history for this message
Pim Vullers (pimvullers) wrote :

The big issue is that contractor support has to be decided upon during compilation. It cannot be controlled through the extension settings list.

Changed in scratch:
status: Invalid → New
summary: - Scratch takes long time to open a (new) file
+ Contractor plugin does not show up in extensions list
Mario Guerriero (mefrio-g)
Changed in scratch:
status: New → Confirmed
status: Confirmed → In Progress
Mario Guerriero (mefrio-g)
Changed in scratch:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.