defstruct constructor uses slot-names in lambda list.

Actually, I'm having second thoughts.

Consider:

(defvar *foo* (list 1 2))

(defun bar ()
  (car *foo*))

(defstruct (foo (:constructor make-foo (*foo* &aux (bar (bar)))))
  *foo*
  bar)

(let ((foo (make-foo (list 'a 'b))))
  (list (foo-*foo* foo) (foo-bar foo))) ; => ((A B) A)

It is not clear to me that this is wrong, and that ((A B) 1) would be right. Renaming user-specified arguments strikes me as suspect: the spec talks about implementation not being allowed to do X, but this is the user explicitly specifying something.

Granted, /not/ considering this a bug means that you cannot use a boa-constructor if you name a slot with a symbol also used as a defconstant or defglobal.

Hm.

For what it's worth, CLtL2 seems to agree that the user-specified names should be used. In https://www.cs.cmu.edu/Groups/AI/html/cltl/clm/node174.html there's the following example:

(defstruct (ice-cream-factory
             (:constructor fabricate-factory
               (&key (capacity 5)
                      location
                      (local-flavors
                        (case location
                          ((hawaii) '(pineapple macadamia guava))
                          ((massachusetts) '(lobster baked-bean))
                          ((california) '(ginger lotus avocado bean-sprout garlic))
                          ((texas) '(jalapeno barbecue))))
                      (flavors (subseq (append local-flavors
                                               '(vanilla chocolate strawberry pistachio maple-walnut peppermint))
                                       0 capacity)))))
  (capacity 3)
  (flavors '(vanilla chocolate strawberry mango)))

The flavors argument refers back to the capacity argument, which is also the name of a slot.

Unfortunately as far as I can tell the standard itself carefully avoids giving any explicit examples like this. The bit about the restriction on naming comes in the section where it's talking about the default keyword-style constructor function that defstruct creates, and it specifically says "THE constructor function" (emphasis mine), so I guess it could be argued it only applies to the default constructor function and not BOA constructors.