sbackup

Simple Backup crashs silently if an io error occurs while doing backup and restoration.

Series 0.10
Bug #290265

Bug #290265 reported by Jean-Peer Lorenz on 2008-10-28

This bug affects 1 person

	Status	Importance	Assigned to
sbackup	Status tracked in Trunk
0.10	Fix Committed	Medium	Unassigned
Trunk	Invalid	Undecided	Unassigned

Bug Description

Simple Backup crashs silently if an io error occurs while doing backup and restoration:

If an io error occurs an exception is raised and the creation of a backup fails silently. Same holds for the restore process.
An io error happens for instance if a directory contains a 'socket'. SBackup tries to store this 'file' but the access fails.

At least a message should appear to inform the user that an error happened! The better way would be to catch such non 'files' before storing them.

Remark: this bug does not exist in NSsbackup.

Tags:

Related branches

lp://staging/~mascha/sbackup/0.10.5_with_fixes

Revision history for this message

Martin Schaaf (mascha) wrote on 2008-10-30:

Please reproduce the exception and paste it here.

Revision history for this message

Jean-Peer Lorenz (peer.loz) wrote on 2008-11-04:

Log IO error while restoration. Edit (1.4 KiB, text/plain)

Hello Martin,

here is the exception output. It happend while restoring some data that originally contained a 'socket' file descriptor. Moreover I attached patches to fix this behaviour:

1. check if the restored file really exists before copying (patch 'srestore-check-for-file.patch')
2. occured exceptions should be caught and presented to the user. If this is not the case, the programm suddenly disappears from the screen and no one knows what happend - no good. (patch 'simple-restore-gnome-with-exception-handling.patch'). The same should be implemented for the backup process but I had no time to prepare a patch.

Thanks.

Revision history for this message

Jean-Peer Lorenz (peer.loz) wrote on 2008-11-04:

check if the restored file really exists before copying Edit (662 bytes, text/plain)

The patches are build against your branch 'sbackup-0.10.5_with_fixes'.

Revision history for this message

Jean-Peer Lorenz (peer.loz) wrote on 2008-11-04:

catches exceptions while restoration for useability Edit (2.6 KiB, text/plain)

Revision history for this message

Martin Schaaf (mascha) wrote on 2008-11-07:

Hi Jean-Peer,

thank you for your patches I applied your patches and changed them a little bit to restore also symlinks and reduced the area for catching exception to the necessary one. I changed also the behaviour of the backup script a little in the way that only files, symlinks and directories are backuped.

Please can you try my latest checkins and Thank you for your help.

martin

Martin Schaaf (mascha) on 2008-11-07

Changed in sbackup:
status:	New → Fix Committed

Revision history for this message

Jean-Peer Lorenz (peer.loz) wrote on 2008-11-10:

Adds some informations about contributors. Edit (339 bytes, text/plain)

Hello,

I've tested the latest version from launchpad and everything worked fine for me. This bug can be closed. Nevertheless I attached a small patch here that includes my email adress to the AUTHORS file. It would be nice if can apply this.

Thank you.
Regards. Jean-Peer.

Revision history for this message

Martin Schaaf (mascha) wrote on 2008-11-16:

Thank you I commited your patch.

Jean-Peer Lorenz (peer.loz) on 2013-01-03