sale_dropshipping: no dropshipping (by default) if stock available
Bug #1287779 reported by
Alexandre Fayolle - camptocamp
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Sales - Workflow and Organization |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Case at hand: I have a product in MTO + buy + supplier does drop shipping.
If the virtual stock available is <=0 a SO for this product will be configured in drop shipping for the SO line.
OTOH, if there is some virtual stock, then the SO line will use the normal sale flow, regardless of the procurement method of the SO line. I think that the fact that the line type is make_to_order should prevent having a "normal" flow in this case, and that the check described above should only be performed for lines with type make_to_stock (in which case we want the order point to be substituted with a drop shipping).
Related branches
lp://staging/~camptocamp/sale-wkfl/7.0-fix_dropshipping_1287779-afe
- Yannick Vaucher @ Camptocamp: Approve
- Pedro Manuel Baeza: Approve (code review)
- Nicolas Bessi - Camptocamp (community): Approve (no test, code review)
-
Diff: 159 lines (+118/-3)4 files modifiedsale_dropshipping/__openerp__.py (+2/-1)
sale_dropshipping/product.py (+3/-1)
sale_dropshipping/sale.py (+2/-1)
sale_dropshipping/test/test_sale_policy_procurement.yml (+111/-0)
Revision history for this message
| Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote | #1 |
Revision history for this message
| Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote | #2 |
| Changed in sale-wkfl: | |
| status: | New → Fix Committed |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hello,
Well practically it can be logic to use your stock first. But in other case you want to always use drop shipping as your supplier can have better condition when delivering product. IMHO this parameter should be at supplier info level, because you may want to have a given behavior by supplier. The problem is that the drop shipping check box does not offer enough flexibility.
I think one solution is to change the boolean fields on supplier info to a selection field with (standard, force drop shipping, drop shipping when no stock) and adapt code consequently.
Regards
Nicolas