Sahara

Sahara always creates ResourceGroup for volumes even if that is not required

Bug #1494650 reported by Vitalii Gridnev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
High
Vitalii Gridnev
Sahara mitaka-1 "m1"
Liberty
Fix Released
High
Vitalii Gridnev
Mitaka
Fix Released
High
Vitalii Gridnev
Sahara mitaka-1 "m1"

Bug Description

Sahara always creates ResourceGroup for volumes even if node group template doesn't have volumes_per_node. It probably can cause validation errors during heat stack validations.

For example, in sahara-ci fake job for saharaclient, we can found that sahara creates 2 RG for volumes, but one of the node groups doesn't need any volumes for storage.

Revision history for this message
Vitalii Gridnev (vgridnev) wrote :

https://sahara.mirantis.com/logs/15/221115/2/check/gate-saharaclient-distributed-heat-fake/b23cb4b/sahara-log-engine-2.txt

Changed in sahara:
assignee: nobody → Vitaly Gridnev (vgridnev)
OpenStack Infra (hudson-openstack)
Changed in sahara:
status: New → In Progress
Sergey Reshetnyak (sreshetniak)
Changed in sahara:
importance: Undecided → Medium
importance: Medium → High
milestone: none → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/220538
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=2b25dfa07fedbbe48cc4f92e9ab1933f87101488
Submitter: Jenkins
Branch: master

commit 2b25dfa07fedbbe48cc4f92e9ab1933f87101488
Author: Vitaly Gridnev <email address hidden>
Date: Fri Sep 4 17:46:55 2015 +0300

    Create ResourceGroup with volumes only if it is required

    If volumes_per_node or volumes_size is 0, there is no sense
    in creating empty ResourceGroup.

    Also remove volumes from one node group in gate to be sure
    that sahara correctly handle such case.

    Closes-bug: 1494650
    Change-Id: Ic592710773b9338f5857e431b0567bc5c87af2bd

Changed in sahara:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in sahara:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in sahara:
milestone: liberty-rc1 → 3.0.0
Revision history for this message
Vitalii Gridnev (vgridnev) wrote :

Reopened bug

Changed in sahara:
status: Fix Released → Confirmed
milestone: 3.0.0 → mitaka-1
OpenStack Infra (hudson-openstack)
Changed in sahara:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/245445
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=faef6379cb1f7ba0ec70dfcbcb61c8d60b17518a
Submitter: Jenkins
Branch: master

commit faef6379cb1f7ba0ec70dfcbcb61c8d60b17518a
Author: Vitaly Gridnev <email address hidden>
Date: Sat Nov 14 22:14:08 2015 +0300

    Remove unneeded volume serialization

    It looks like this serialization introduced
    because of some rebase, anyway it's clear that
    it's unneeded.

    Closes-bug: 1494650
    Change-Id: If0140ca9f22fb3073fafccada512c877322efc2d

Changed in sahara:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/248101

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (stable/liberty)

Reviewed: https://review.openstack.org/248101
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=a6b3a8803e92e08f3fc65f59a64221419661c2b4
Submitter: Jenkins
Branch: stable/liberty

commit a6b3a8803e92e08f3fc65f59a64221419661c2b4
Author: Vitaly Gridnev <email address hidden>
Date: Sat Nov 14 22:14:08 2015 +0300

    Remove unneeded volume serialization

    It looks like this serialization introduced
    because of some rebase, anyway it's clear that
    it's unneeded.

    Closes-bug: 1494650
    Change-Id: If0140ca9f22fb3073fafccada512c877322efc2d
    (cherry picked from commit faef6379cb1f7ba0ec70dfcbcb61c8d60b17518a)

Doug Hellmann (doug-hellmann)
Changed in sahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.