Sahara

[UI] The "Plugin Select" dialogs use unnecessary javascript

Bug #1410941 reported by Chad Roberts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Undecided
Unassigned
Sahara
Triaged
Medium
Unassigned
Sahara pike-2 "p2"

Bug Description

* This is a technical debt item that is leftover from when we merged the Sahara dashboard into horizon.

When clicking on the "create/launch" button for node group templates, cluster templates, or clusters the user is presented with a form to choose their plugin and version. Currently, the "version" select boxes are hidden or shown by some custom javascript on each of those pages. Instead, the switched/switchable mechanic from horizon should be used to control the appearance/hiding of each of the version dropdowns.

Tags: dashboard
Revision history for this message
Chad Roberts (croberts) wrote :

Will take care of this for Liberty

Changed in horizon:
assignee: nobody → Chad Roberts (croberts)
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Sahara content now lives in https://github.com/openstack/sahara-dashboard

Changed in horizon:
assignee: Chad Roberts (croberts) → nobody
status: New → Invalid
Rob Cresswell (robcresswell-deactivatedaccount)
tags: added: dashboard
removed: sahara
summary: - [data processing] The "Plugin Select" dialogs use unnecessary javascript
+ [UI] The "Plugin Select" dialogs use unnecessary javascript
Vitalii Gridnev (vgridnev)
Changed in sahara:
importance: Undecided → Medium
milestone: none → newton-1
milestone: newton-1 → none
status: New → Confirmed
Chad Roberts (croberts)
Changed in sahara:
assignee: nobody → Chad Roberts (croberts)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/298815

Changed in sahara:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara-dashboard (master)

Reviewed: https://review.openstack.org/298815
Committed: https://git.openstack.org/cgit/openstack/sahara-dashboard/commit/?id=1922c5dd7cd6ecfa807284711d423818fcac2b62
Submitter: Jenkins
Branch: master

commit 1922c5dd7cd6ecfa807284711d423818fcac2b62
Author: Chad Roberts <email address hidden>
Date: Tue Mar 29 11:14:54 2016 -0400

    Simplifying plugin select logic

    This is the first small step in making the plugin select
    logic more conformant with a regular workflow.
    Here, we change the plugin and versions into switched
    form fields, eliminating the javascript that used to
    handle that.

    Change-Id: I23145e340f37b25cfc63446ec381730521d066b0
    Partial-Bug: #1410941

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara-dashboard (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/310225

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara-dashboard (stable/mitaka)

Reviewed: https://review.openstack.org/310225
Committed: https://git.openstack.org/cgit/openstack/sahara-dashboard/commit/?id=fefd609b6b2b215321ac2062dedf36715fd467bd
Submitter: Jenkins
Branch: stable/mitaka

commit fefd609b6b2b215321ac2062dedf36715fd467bd
Author: Chad Roberts <email address hidden>
Date: Tue Mar 29 11:14:54 2016 -0400

    Simplifying plugin select logic

    This is the first small step in making the plugin select
    logic more conformant with a regular workflow.
    Here, we change the plugin and versions into switched
    form fields, eliminating the javascript that used to
    handle that.

    Change-Id: I23145e340f37b25cfc63446ec381730521d066b0
    Partial-Bug: #1410941
    (cherry picked from commit 1922c5dd7cd6ecfa807284711d423818fcac2b62)
    Closes-Bug: #1578235

tags: added: in-stable-mitaka
Vitalii Gridnev (vgridnev)
tags: removed: in-stable-mitaka
Vitalii Gridnev (vgridnev)
Changed in sahara:
milestone: none → newton-2
Vitalii Gridnev (vgridnev)
Changed in sahara:
milestone: newton-2 → newton-3
Vitalii Gridnev (vgridnev)
Changed in sahara:
milestone: newton-3 → none
Vitalii Gridnev (vgridnev)
Changed in sahara:
status: In Progress → Triaged
assignee: Chad Roberts (croberts) → nobody
Revision history for this message
Marianne Linhares Monteiro (mariannelinharesm) wrote :

I think this bug can be "closed, I checked and all the cluster pages seem to be using "switched/switchable"

Telles Mota Vidal Nóbrega (tellesmvn)
Changed in sahara:
milestone: none → pike-2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.