review-tools

hidraw plug makes review-tools unhappy

Bug #2012652 reported by Daniel Manrique
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
review-tools
Invalid
Undecided
Unassigned

Bug Description

Hi, we have a snap with a plug like so:
plugs:
  hidraw-devices-plug:
    interface: hidraw
    usb-vendor: 8000
    usb-product: 30
    path: /dev/hidraw-whatever

(I changed the actual values slightly for confidentiality reasons)

Samuele confirmed the plug declaration should be supported. ifacetools says the snap is installable on a device and this does auto-connect, but review-tools (20230314-0123UTC) says:

declaration malformed (attribute 'path' wrong for 'plugs') declaration-snap-v2_valid_plugs (hidraw, allow-auto-connection_plug-attributes)
unknown attribute 'path' for interface 'hidraw' (plugs) lint-snap-v2_plugs_attributes (hidraw-devices-plug, path)
unknown attribute 'usb-product' for interface 'hidraw' (plugs) lint-snap-v2_plugs_attributes (hidraw-devices-plug, usb-product)
unknown attribute 'usb-vendor' for interface 'hidraw' (plugs) lint-snap-v2_plugs_attributes (hidraw-devices-plug, usb-vendor)

Revision history for this message
Alex Murray (alexmurray) wrote :

hidraw only supports these attributes on the slot side, not the plug - see https://github.com/snapcore/snapd/blob/master/interfaces/builtin/hidraw.go#L76 - so review-tools is doing the right thing from what I can see.

Changed in review-tools:
status: New → Incomplete
Revision history for this message
Daniel Manrique (roadmr) wrote :

Samuele confirmed I'm the one doing it wrong :) Thanks, I'll close this bug report.

Changed in review-tools:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.