Config system needs an overhaul
Bug #607380 reported by
Jeremy Thurgood
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Renamer |
Fix Committed
|
Medium
|
Jonathan Jacobs | ||
Bug Description
The current configuration system, insofar as it exists at all, is somewhat suboptimal.
It should probably be replaced by a global config that allows setting things like default script path, etc. and includes sections for plugins. At the very least, using a proper config parser (maybe ConfigParser? does Twisted have something better?) rather than line.split('=', 1) would make the whole thing less fragile.
Related branches
lp://staging/~renamer-developers/renamer/config-file
- Tristan Seligmann: Approve
-
Diff: 731 lines (+435/-47)11 files modifiedrenamer/_version.py (+1/-1)
renamer/application.py (+74/-25)
renamer/config.py (+132/-0)
renamer/irenamer.py (+7/-3)
renamer/plugin.py (+4/-4)
renamer/plugins/undo.py (+11/-13)
renamer/test/data/test.conf (+8/-0)
renamer/test/test_actions.py (+1/-1)
renamer/test/test_config.py (+127/-0)
renamer/test/test_util.py (+50/-0)
renamer/util.py (+20/-0)
Revision history for this message
| Jonathan Jacobs (jjacobs) wrote | #1 |
| Changed in renamer: | |
| milestone: | none → 0.1.0 |
| Changed in renamer: | |
| milestone: | 0.1.0 → 0.1.1 |
| Changed in renamer: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in renamer: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Jonathan Jacobs (jjacobs) |
| milestone: | 0.1.1 → 0.1.0 |
| Changed in renamer: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
I think this bug is still valid with the upcoming framework/API changes, however the description needs to be updated. We should probably discuss the functionality for this at length.