Ubuntu Notes app

Can't build with phablet-tools

Bug #1308280 reported by Alan Pope 🍺🐧🐱 🦄
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu File Manager App
Fix Released
High
Unassigned
Ubuntu Notes app
Fix Released
High
Unassigned

Bug Description

Core apps which rely on cmake for building currently can utilize both Qtcreator and click-buddy and related tools to build the project. However, click-buddy and qtcreator expect separate layouts, including different manifest files which are not compatible with each other.

The result is the affected apps will not build with click-buddy at the moment. A proposal to fix this issue needs to not break the qtcreator build capability.

See original description

Related branches

lp://staging/~nskaggs/ubuntu-filemanager-app/fix-click-buddy-build
Carlos Jose Mazieri: Approve
Diff: 203 lines (+47/-39)
5 files modified
CMakeLists.txt (+10/-13)
click/CMakeLists.txt (+8/-0)
click/apparmor.json (+4/-3)
click/manifest.json.in (+8/-8)
src/app/main.cpp (+17/-15)
lp://staging/~nskaggs/reminders-app/cmake-build-test
Nicholas Skaggs (community): Disapprove
Leo Arias (community): Approve
Diff: 184 lines (+44/-36)
5 files modified
CMakeLists.txt (+24/-23)
click/CMakeLists.txt (+8/-0)
click/manifest.json.in (+7/-7)
src/app/main.cpp (+4/-2)
tests/autopilot/reminders/tests/__init__.py (+1/-4)
lp://staging/~dpm/ubuntu-filemanager-app/click-everywhere
Nicholas Skaggs (community): Approve
Carlos Jose Mazieri: Approve
Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
Diff: 37 lines (+8/-4)
2 files modified
CMakeLists.txt (+5/-1)
manifest.json (+3/-3)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I'm seeing build failures :-(

/ubuntu-filemanager-app/src/plugin/folderlistmodel/dirmodel.cpp:43:41: fatal error: taglib/attachedpictureframe.h: No such file or directory
 #include <taglib/attachedpictureframe.h>
                                         ^
compilation terminated.
make[2]: *** [src/plugin/folderlistmodel/CMakeFiles/folderlistmodel.dir/dirmodel.cpp.o] Error 1
make[1]: *** [src/plugin/folderlistmodel/CMakeFiles/folderlistmodel.dir/all] Error 2
make: *** [all] Error 2
Usage: click build [options] DIRECTORY

You don't have to use phablet-test-setup, so I'm curious if the tests run or not.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

My build issue was because of not having build deps installed in my chroot.. d'oh. The underlying reason here is the manifest file contains the revno of 'latest' instead of a number. In general, the modifications to the cmake build break click-buddy and phablet tools.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

After playing around with reverting these changes I can see the resulting clicks are exactly the same. Still, file manager doesn't run on devices, complaining of missing the plugin.

ubuntu-filemanager-app.qml:20 module "org.nemomobile.folderlistmodel" is not installed

summary: - Can't setup autopilot
+ Can't build with phablet-tools
Nicholas Skaggs (nskaggs)
Changed in ubuntu-filemanager-app:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

The summary of this bug is that qtcreator and click-buddy need separate layouts, including different manifest files which are not compatible with each other. There doesn't seem to yet be an easy way to allow both to build projects easily, so enabling qtcreator builds breaks click tools and vice-versa. This should track the affected apps.

The long-term solution is to get everyone on the same page, as far as tooling goes. In the short-term, it would be nice to figure out a workaround for these issues.

Changed in reminders-app:
status: New → Confirmed
importance: Undecided → High
Nicholas Skaggs (nskaggs)
description: updated
description: updated
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-filemanager-app at revision 163, scheduled for release in ubuntu-filemanager-app, milestone alpha-1

Changed in ubuntu-filemanager-app:
status: Confirmed → Fix Committed
David Planella (dpm)
Changed in reminders-app:
status: Confirmed → Fix Committed
David Planella (dpm)
Changed in ubuntu-filemanager-app:
status: Fix Committed → Fix Released
Changed in reminders-app:
status: Fix Committed → Fix Released
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Hi.
I tried to builld filemanager and I have following error:

[ 73%] Building CXX object src/plugin/folderlistmodel/CMakeFiles/nemofolderlistmodel.dir/dirmodel.cpp.o
/home/a/dev/coreapps/ubuntu-filemanager-app/src/plugin/folderlistmodel/dirmodel.cpp:43:41: fatal error: taglib/attachedpictureframe.h: No such file or directory
 #include <taglib/attachedpictureframe.h>
                                         ^
compilation terminated.
make[2]: *** [src/plugin/folderlistmodel/CMakeFiles/nemofolderlistmodel.dir/dirmodel.cpp.o] Error 1
make[1]: *** [src/plugin/folderlistmodel/CMakeFiles/nemofolderlistmodel.dir/all] Error 2
make: *** [all] Error

Do you know how to resolve it?

Revision history for this message
David Planella (dpm) wrote :

Hi Bartosz,

Yes, please read the README file in the source directory, which explains you which dependencies you need to install to build the file manager app.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.