MTR testcase creation fails due to a regex in test.Pm

May be a simple newline change/fixup in the code

This is a result of a regexp on line 194 in lib/GenTest/Simplifier/Test.pm whose task was to pretty-print the SQL statement.

How about if we remove the regex completely? The pretty print function makes the MTR testcases longer and less clean. It could potentially help devs to analyze the issue though.

No problem. Feel free to remove and/or fix the regexp. You can also pretty-print the test cases manually when you file them, depending on the requirements of your developers.

I find pretty-printing useful for two reasons:

1) Easier to read and understand the actual query (no need to have a 100" monitor to see the entire query). However, the current pretty printing is far from perfect in that regard, so I often tend to prettify the SQL more or less manually when I need to (for myself or for developers), anyway.

2) Further automatic simplification of MTR test cases. The RQG test simplifier works on a line-by-line basis, right? So if the query is split into multiple lines, it can more easily simplify the actual query. This seems especially useful when the initial automatic simplification fails for some reason, where you still may get a test case with the original query pretty-printed, which you can massage slightly and then initiate further simplification using simplify-mysqltest.pl.

Will removing the pretty-print regexp lead to a reduced ability to automatically simplify queries in Transformer / ResultsetComparator context?

If not, I guess removing it is fine. Otherwise, the regexp should take care so that function calls are not split (no whitespace between function name and opening parenthesis).

Seems to be happening in more cases. Another example:

/* GenTest::Transform::ExecuteAs
WhereSubquery */ DROP TABLE IF EXISTS transforms.
where_sub
select_14617; CREATE TABLE transforms.
where_sub
select_14617

Looking at the example above:

- "WhereSubquery" was put on a new line while it is part of a comment
- where_sub was put on a new line, likely because it starts with "where" or because of the ".", but it should have been left as part of the db.tablename
- select_... was put on a new line while it was part of a tablename

John, maybe the automatic simplification is sometimes failing exactly because of this chopping up...

Philip, what is your take on this/John's question?

Would be good to get this one fixed since it affects a lot of MTR testcase for transformer sets.

Noticed a similar issue with ExecuteAsUpdateDelete
/* GenTest::Transform::ExecuteAsInsert
Select */ DROP TABLE IF EXISTS transforms.insert_
select_28983; CREATE TABLE transforms.insert_
select_28983

The $rewritten_query in test.pm may require a regex correction.

As well as ExecuteAsInsert transform.