ubuntu-project templates are not PEP 8 compliant

Bug #483934 reported by Jonathan Lange
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Quickly
Triaged
Low
Unassigned

Bug Description

It would be nice if Quickly generated code that conforms to the normal standard for Python code: PEP 8.

The ubuntu-project templates at the least are not PEP 8 compliant.

$ find . -name '*.py' | xargs /home/jml/bin/pep8.py
./setup.py:7:80: E501 line too long (89 characters)
./setup.py:26:25: W291 trailing whitespace
./setup.py:67:5: E301 expected 1 blank line, found 0
./setup.py:92:56: E202 whitespace before ')'
./setup.py:94:1: W391 blank line at end of file
./lister/listerconfig.py:18:1: E302 expected 2 blank lines, found 1
./lister/PreferencesListerDialog.py:59:48: E231 missing whitespace after ':'
./lister/PreferencesListerDialog.py:63:95: E225 missing whitespace around operator

Also, docstrings should have a short first line, a blank line and then extended text, as per PEP 257.

http://www.python.org/dev/peps/pep-0008/
http://www.python.org/dev/peps/pep-0257/

I personally would mark this as a really low priority issue and suggest that the person filing the ticket provide a patch, but that's just me.

$ ~/src/quickly/trunk/bin/quickly --version
Quickly 0.1
  Python interpreter: /usr/bin/python 2.6.4
  Python standard library: /usr/lib/python2.6

  Quickly used library: /home/jml/src/quickly/trunk/quickly
  Quickly data path: /home/jml/src/quickly/trunk/data
  Quickly detected template directories:
          /home/jml/src/quickly/trunk/data/templates/

Copyright 2009 Canonical Ltd.
  #Author 2009 Rick Spencer
  #Author 2009 Didier Roche
https://launchpad.net/quickly

quickly comes with ABSOLUTELY NO WARRANTY. quickly is free software, and
you may use, modify and redistribute it under the terms of the GNU
General Public License version 3 or later.

Jonathan Lange (jml)
description: updated
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks Jonathan for your bug report.

Indeed, we should consider that as it seems we don't have so many issue on PEP8. Should be handled quickly.
Can you please point me to your script to check that easily? I didn't find it on the pep8 page.
Thanks a lot.

PS: still on Quickly 0.1? We now have 0.2.6 but the generated project didn't changed so much :)

Changed in quickly:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Jonathan Lange (jml) wrote :

https://code.edge.launchpad.net/~vcs-imports/pep8/trunk

Reason I'm running an old version is because of Bazaar format difficulties. Fixing now.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.