Tracks don't sort by disc number
Bug #1246172 reported by
Dennis O'Flaherty
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
QtDeclarative bindings for the Grilo media scanner |
Won't Fix
|
Wishlist
|
Unassigned | ||
Ubuntu Music App |
Fix Released
|
Wishlist
|
Unassigned | ||
mediascanner2 |
Fix Released
|
Undecided
|
Unassigned | ||
mediascanner2 (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I have an album with two discs and the songs play in the following order:
Disc2, Track1
Disc1, Track1
Disc2, Track2
Disc1, Track2
(and so on...)
I would expect that they be played:
Disc1, Track1
Disc1, Track2
...
Disc1, TrackN
Disc2, Track1
Disc2, Track2
...
Disc2, TrackM
Some investigation into this shows that disc number is not being tracked in the music app, there are no QtGrilo bindings for it or even a field for it in the grilo library.
Related branches
lp://staging/~jamesh/mediascanner2/qmlplugin-updates
- Jussi Pakkanen (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 905 lines (+228/-110)20 files modifiedsrc/daemon/MetadataExtractor.cc (+4/-0)
src/mediascanner/MediaFile.cc (+13/-3)
src/mediascanner/MediaFile.hh (+7/-3)
src/mediascanner/MediaFileBuilder.cc (+17/-1)
src/mediascanner/MediaFileBuilder.hh (+10/-2)
src/mediascanner/MediaStore.cc (+30/-22)
src/qml/Ubuntu/MediaScanner/AlbumModelBase.cc (+4/-0)
src/qml/Ubuntu/MediaScanner/AlbumModelBase.hh (+3/-0)
src/qml/Ubuntu/MediaScanner/ArtistsModel.cc (+4/-0)
src/qml/Ubuntu/MediaScanner/ArtistsModel.hh (+3/-0)
src/qml/Ubuntu/MediaScanner/MediaFileModelBase.cc (+10/-0)
src/qml/Ubuntu/MediaScanner/MediaFileModelBase.hh (+5/-0)
src/qml/Ubuntu/MediaScanner/MediaFileWrapper.cc (+8/-0)
src/qml/Ubuntu/MediaScanner/MediaFileWrapper.hh (+4/-0)
src/qml/Ubuntu/MediaScanner/plugin.qmltypes (+28/-3)
src/utils/scaletest.cc (+1/-1)
test/qml/tst_mediastore.qml (+2/-0)
test/qml/tst_songsearchmodel.qml (+6/-6)
test/test_mediastore.cc (+62/-62)
test/test_qml.cc (+7/-7)
Changed in qtgrilo: | |
importance: | Undecided → Wishlist |
Changed in music-app: | |
importance: | Undecided → Wishlist |
Changed in qtgrilo: | |
status: | New → Triaged |
Changed in music-app: | |
status: | New → Triaged |
affects: | mediascanner → mediascanner2 |
Changed in mediascanner2: | |
status: | New → In Progress |
Changed in mediascanner2: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
In the new media scanner code base, we're currently only storing the track number in the index. It shouldn't be a big deal to also store the disc number and use it for the relevant sorted queries.