Bookmarklet is not URI safe for including on a page
Bug #782930 reported by
David Coles
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
qrify |
Fix Committed
|
Medium
|
Unassigned |
Bug Description
The bookmarklet doesn't escape characters like `"` when generating the minified version. While fine for adding by hand, you can't put it on a page for drag/dropping. Should probably be URI encoded using Python's quote.
(As a slightly separate note maybe we should build a minified version and then use that to build a "qrify.url" file. The "qrify-min.js" isn't really a valid Javascript source file with the "javascript:" out front.)
Related branches
To post a comment you must log in.
Adding Matt since I'm kind of curious to hear his thoughts, since he wrote the bookmarklet.py script.