Library versions not displayed in About box

Bug #1330303 reported by Martin Spacek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qpdfview
Fix Released
Wishlist
Martin Spacek

Bug Description

It would be nice to have the version numbers of at least some of the libraries qpdfview depends on shown in the About box. I'll submit a branch that does this.

Related branches

Revision history for this message
Martin Spacek (mspacek) wrote :

Submitted libver branch

Revision history for this message
Adam Reichold (adamreichold) wrote :

Hello Martin,

thank you for your contribution! The linked branch looks good and it'll merge it ASAP.

Best regards, Adam.

P.S.: For future contributions, I encourage you not to use a bug report, but a merge request which keeps the bug tracker tidy and is also more useful code review because of the inline diff? (The "Propose for merging" button on a branch's page creates such a request.) Thanks!

Changed in qpdfview:
status: New → In Progress
importance: Undecided → Wishlist
milestone: none → 0.4.11
assignee: nobody → Martin Spacek (mspacek)
Revision history for this message
Adam Reichold (adamreichold) wrote :

Hello again,

merged. A minor thing, I did add fallback defines so that the program would compile without pkg-config (and without manually adding the "DEFINES +=" statements) and also added Fitz and CUPS to mix. (I don't known how to automatically determine the Fitz version, but CUPS comes with its own "cups-config" helper.)

Best regards, Adam.

Changed in qpdfview:
status: In Progress → Fix Committed
Revision history for this message
Martin Spacek (mspacek) wrote :

You're welcome! Sure, next time I'll just do a merge request. I'm a lot less familiar with launchpad than github.

Ah, I guess I forgot to cover the case in mainwindow.cpp where the library is available, but pkg-config wasn't. Thanks for adding the CUPS version.

I think you made an error for libspectre. At lines 113-114 two different names are used: SPECTRE_VERSION and LIBSPECTRE_VERSION. As a result, the libspectre version number doesn't actually show up in the About box any more.

Revision history for this message
Martin Spacek (mspacek) wrote :

That should've read lines 113-114 in application.pro

Revision history for this message
Adam Reichold (adamreichold) wrote : Re: [Bug 1330303] Re: Library versions not displayed in About box

Am 16.06.2014 22:39, schrieb Martin Spacek:
> You're welcome! Sure, next time I'll just do a merge request. I'm a
> lot less familiar with launchpad than github.
>
> Ah, I guess I forgot to cover the case in mainwindow.cpp where the
> library is available, but pkg-config wasn't. Thanks for adding the
> CUPS version.
>
> I think you made an error for libspectre. At lines 113-114 two
> different names are used: SPECTRE_VERSION and LIBSPECTRE_VERSION.
> As a result, the libspectre version number doesn't actually show up
> in the About box any more.
>

Yes, you're right. Fixed that in trunk revision 1577. Thanks!

Changed in qpdfview:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.