qrun failed to start if some command has no help

Bug #595331 reported by treaves
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Confirmed
High
Unassigned
bzr-pipeline
Invalid
Undecided
Unassigned

Bug Description

In Explorer, when I hit the All button, it go boom. OS X 10.6.4, Bazaar 2.2b3, PyQt4.7.3

The stack is:
bzr: ERROR: exceptions.ValueError: No help message set for <bzrlib.plugins.pipeline.commands.cmd_store object at 0x115487250>

Traceback (most recent call last):
  File "/Library/Python/2.6/site-packages/bzrlib/plugins/qbzr/lib/commands.py", line 166, in run
    ret_code = self._qbzr_run(*args, **kwargs)
  File "/Library/Python/2.6/site-packages/bzrlib/plugins/qbzr/lib/commands.py", line 1040, in _qbzr_run
    execute=execute)
  File "/Library/Python/2.6/site-packages/bzrlib/plugins/qbzr/lib/run.py", line 67, in __init__
    self.collect_command_names()
  File "/Library/Python/2.6/site-packages/bzrlib/plugins/qbzr/lib/run.py", line 167, in collect_command_names
    for n in names)
  File "/Library/Python/2.6/site-packages/bzrlib/plugins/qbzr/lib/run.py", line 167, in <genexpr>
    for n in names)
  File "/Library/Python/2.6/site-packages/bzrlib/commands.py", line 240, in get_cmd_object
    return _get_cmd_object(cmd_name, plugins_override)
  File "/Library/Python/2.6/site-packages/bzrlib/commands.py", line 262, in _get_cmd_object
    cmd = hook(cmd, cmd_name)
  File "/Library/Python/2.6/site-packages/bzrlib/commands.py", line 332, in _get_plugin_command
    return plugin_cmds.get(cmd_name)()
  File "/Library/Python/2.6/site-packages/bzrlib/commands.py", line 411, in __init__
    raise ValueError("No help message set for %r" % self)
ValueError: No help message set for <bzrlib.plugins.pipeline.commands.cmd_store object at 0x115487250>

bzr 2.2b3 on python 2.6.1 (darwin)
arguments: ['/usr/local/bin/bzr', 'qrun', '--ui-mode']
encoding: 'utf-8', fsenc: 'utf-8', lang: 'en_US.utf-8'
plugins:
  bash_completion /Library/Python/2.6/site-packages/bzrlib/plugins/bash_completion [2.2b3]
  bzrtools /Library/Python/2.6/site-packages/bzrlib/plugins/bzrtools [2.2.0]
  colo /Library/Python/2.6/site-packages/bzrlib/plugins/colo [0.2.0dev]
  email /Library/Python/2.6/site-packages/bzrlib/plugins/email [unknown]
  explorer /Library/Python/2.6/site-packages/bzrlib/plugins/explorer [1.1.0dev]
  extmerge /Library/Python/2.6/site-packages/bzrlib/plugins/extmerge [unknown]
  fastimport /Library/Python/2.6/site-packages/bzrlib/plugins/fastimport [0.9.0dev]
  keychain /Library/Python/2.6/site-packages/bzrlib/plugins/keychain [0.1.0]
  launchpad /Library/Python/2.6/site-packages/bzrlib/plugins/launchpad [2.2b3]
  loom /Library/Python/2.6/site-packages/bzrlib/plugins/loom [2.1.1dev]
  netrc_credential_store /Library/Python/2.6/site-packages/bzrlib/plugins/netrc_credential_store [2.2b3]
  news_merge /Library/Python/2.6/site-packages/bzrlib/plugins/news_merge [2.2b3]
  pipeline /Library/Python/2.6/site-packages/bzrlib/plugins/pipeline [unknown]
  qbzr /Library/Python/2.6/site-packages/bzrlib/plugins/qbzr [0.19.0dev1]
  rewrite /Library/Python/2.6/site-packages/bzrlib/plugins/rewrite [0.6.1dev]
  svn /Library/Python/2.6/site-packages/bzrlib/plugins/svn [1.0.3dev]
  upload /Library/Python/2.6/site-packages/bzrlib/plugins/upload [1.0.0dev]
  xmloutput /Library/Python/2.6/site-packages/bzrlib/plugins/xmloutput [0.8.7.dev]

Revision history for this message
Alexander Belchenko (bialix) wrote :

It's the bug n QBzr plugin but due pipeline plugin. As you can see `store` command from pipleine plugin has no help. Maybe there is newer version of pipeline plugin with that help added?

Changed in qbzr:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 595331] Re: All button blows up

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> It's the bug n QBzr plugin but due pipeline plugin. As you can see
> `store` command from pipleine plugin has no help. Maybe there is newer
> version of pipeline plugin with that help added?
>
> ** Changed in: qbzr
> Status: New => Confirmed
>
> ** Changed in: qbzr
> Importance: Undecided => High
>

I believe Aaron's specific comment was (paraphrased):
  It is a hidden command for my personal use, I don't feel the need to
  write docs for it.

Anyway, it is probably pretty unlikely that he'll have docs for it, but
at the least, some *other* command could certainly not have docs, and
thus qbzr should handle that case.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwZsBEACgkQJdeBCYSNAAM+3QCgx/f7pwNaJ9UkpSupFamLfs4v
sSMAn2GHmzlzK64+8cu7P8zO6ZbP9cOl
=Wqvn
-----END PGP SIGNATURE-----

Revision history for this message
Alexander Belchenko (bialix) wrote :

John A Meinel пишет:

Thank you for your comment.

> Alexander Belchenko wrote:
>> It's the bug n QBzr plugin but due pipeline plugin. As you can see
>> `store` command from pipleine plugin has no help. Maybe there is newer
>> version of pipeline plugin with that help added?
>>
>> ** Changed in: qbzr
>> Status: New => Confirmed
>>
>> ** Changed in: qbzr
>> Importance: Undecided => High
>>
>
> I believe Aaron's specific comment was (paraphrased):
> It is a hidden command for my personal use, I don't feel the need to
> write docs for it.

I did not know this, and I personally don't use pipeline, so I don't
know which command is hidden.

> Anyway, it is probably pretty unlikely that he'll have docs for it, but
> at the least, some *other* command could certainly not have docs, and
> thus qbzr should handle that case.

Yes, of course QBzr should be fixed. I've just suggested to check for
newer version of pipeline because I did not know about Aaron's position.

Thank you for clarification.

--
All the dude wanted was his rug back

Changed in bzr-pipeline:
status: New → Invalid
summary: - All button blows up
+ qrun failed to start if some command has no help
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.