crash on null commit using bzr qcommit --ui-mode in branch of shared repo

Bug #473443 reported by Martitza
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
New
Undecided
Unassigned

Bug Description

Using bzr-explorer (that's how I found this issue, may not be the only way):
Initialized a shared repo (selected "Feature Branches" in init dialog) called 'test-project'
Output pane (of init) shows that the shared repo has been created *and* a branch called trunk has been created inside the repo.

Open location of shared repo, double click on branch 'trunk'.
So now we are staring at an up-to-date branch 'trunk at revision 0.
So invoke commit anyway and when prompted say 'yes, commit even though no changes' ==> crash dump attached.

Just for sanity, go to the command line and issue

$ bzr commit --unchanged -m "null commit"
Committing to: /home/maritza/Projects/test-project/trunk/
Committed revision 1.

No problem on the command line. Per Alexander, this may (?) be related to Bug #299879 (https://bugs.launchpad.net/bzr/+bug/299879) because the actual command issued by qbzr may (?) have the '--exclude .' issue.

I have seen this specific problem only on branches in shared repos. Stand-alone branches seem to be fine, but I have not tested enough to rule that out conclusively.

I have worked successfully with shared repos in the past, but that was with bzr 1.18, qbzr 0.14, bzr-explore 0.7 and python 2.6.2 all on Jaunty. Now I am running bzr 2.0.1, qbzr 0.16, bzr-explore 0.9 and python 2.6.4 on Karmic. So...a lot has changed and I can't make any strong except what I see.

Revision history for this message
Martitza (martitzam) wrote :

Sure enough. Let's go to the command line...

$ mkdir T
$ cd T
$ bzr init-repo myrepo
$ cd myrepo
$ bzr init mybranch
$ bzr commit -m "null commit" -x . --unchanged
# ... crashfile attached
$ bzr commit -m "null commit" --unchanged
Committing to: /home/maritza/Projects/T/myrepo/mybranch/
Committed revision 1.

And just as Alexander pointed out in qbzr revno 539 near in libcommit.py line 640...

                    # 2. if branch has no commits yet then operation may fail
                    # because of bug #299879
                    args.extend(['--exclude', self.tree.basedir])

This is consistent with the attached crash report.

Together, these observations appear to support the hypothesis that the observed crash can be traced back to Bug #299879 in bzr itself.

Revision history for this message
Martitza (martitzam) wrote : Re: [Bug 473443] Re: crash on null commit using bzr qcommit --ui-mode in branch of shared repo

I agree that the root cause of this bug is Bug 299879. I also think that
the manifestation of this bug in qbzr (and by extension Bazaar Explorer) is
enough to warrant additional weight on Bug 299879.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.