Comment 9 for bug 295130

> I must sort out my EOL issues when it comes to bzr.

Sorry, I wasn't clear - there don't seem to be "bad" EOL chars - just some trailing whitespace just before the EOL chars. They often sneak in, but doing a diff against the parent shows them, so I go back and fix them - similarly for 'accidental' blank lines I introduced. I like my diffs looking as small as possible :)

> (what IDE are you using?

I use komodo, but an editor like Scite is useful and has excellent whitespace and EOL capabilities.

> I've noticed that too and fixed it in my bug fix branch: lp:~craighewetson/qbzr/trunk
> I must look at the coding standards for python (coming from a java background I will have to watch myself)

Yeah - please google 'pep8'. If you change your branch to use 'checked_files' as the variable name I'd be happy to merge it. Sorry if it sounds picky :)

> >>FYI, "bzr [q]diff -rancestor:..\path-to-trunk" ...
> I was thinking of incorporating this into the qpush dialog

Sounds reasonable!

> Since i wanted to reuse a tab widget in the commit window,
> i tried to extract the set of widgets as a unit or blackbox.

Yeah, that sounds worthwhile - although you may find its better to encapsulate the *behaviour* of the widgets rather than the actual widgets and their layout, as each form might have subtly different layout semantics. The 'WorkingTreeFileList' widget is an example of this, but I can see how it does makes sense when talking about tabs.

However - I can't see any particular problems with the implementation in commit.py that would prevent refactoring. What issue with globals are you referring to?

> I've only started learning python about 2 weeks ago, and pyQT less than that.

Awesome - excellent work :) Its probably worthwhile to move towards this goal anyway to reduce the duplication - we will be more than happy to help.

BTW - what branch is this being tracked in now - lp:~craighewetson/qbzr/push-missing ?