guest_config_minidisks would conflict when called more than one time

Bug #1770063 reported by dyyang@cn.ibm.com
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zVM Cloud Connector
Confirmed
Medium
nafeiyang

Bug Description

guest_config_minidisks is to update a minidisk, so the vdev should be required to specify which disk to update.

Current code would each time use root_vdev+1 as the first disk and /mnt/ephemaral0 as the first mount point. So when the guest_config_minidisks is called for more than one time, unless user specify the vdev and mnt point explicitly, would lead to conflict.

    def process_additional_minidisks(self, userid, disk_info):
        '''Generate and punch the scripts used to process additional disk into
        target vm's reader.
        '''
        for idx, disk in enumerate(disk_info):
            vdev = disk.get('vdev') or self.generate_disk_vdev(
                                                    offset = (idx + 1))
            fmt = disk.get('format')
            mount_dir = disk.get('mntdir') or ''.join(['/mnt/ephemeral',
                                                       str(idx)])

From users' perspective, I think this is unreasonable.

Tags: doc
nafeiyang (nafeiy)
Changed in python-zvm-sdk:
assignee: nobody → nafeiyang (nafeiy)
Revision history for this message
nafeiyang (nafeiy) wrote :

It's from openstack driver's requirement that we can't specify the vdev as required, since openstack driver doesn't know the vdev of ephemeral disk, it just know the format.
We can update doc to recommend customer to specify the vdev, format and mountpoint explicitly, since if customer want to configure these disk, he already the info for the disk he want to configure. Will update doc for it.

Huang Rui (bjhuangr)
Changed in python-zvm-sdk:
importance: Undecided → Medium
Huang Rui (bjhuangr)
Changed in python-zvm-sdk:
status: New → Triaged
Revision history for this message
jichenjc (jichenjc) wrote :

I assume this is a doc update only bug? if that's true, I tagged with 'doc'

tags: added: doc
Revision history for this message
nafeiyang (nafeiy) wrote :
Changed in python-zvm-sdk:
status: Triaged → Fix Committed
jichenjc (jichenjc)
Changed in python-zvm-sdk:
status: Fix Committed → Confirmed
Revision history for this message
Huang Rui (bjhuangr) wrote :

has this been fixed?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.