| 2014-07-14 18:46:50 |
Suthan Venkataramanaiah |
bug |
|
|
added bug |
| 2014-07-14 18:47:32 |
Suthan Venkataramanaiah |
python-troveclient: assignee |
|
Suthan Venkataramanaiah (svenkataramanaia) |
|
| 2014-07-14 18:56:07 |
OpenStack Infra |
python-troveclient: status |
New |
In Progress |
|
| 2014-07-14 19:01:02 |
Mat Lowery |
description |
Recently in trove a "list" API call change has been made to return IP or hostname -https://bugs.launchpad.net/trove/+bug/1339400 in order to improve performance in Trove instance list .
Now , In python trove client it checks for hostname and make an extra api call for each instances on the list. So we need to prevent this extra call as hostname is still going to be none . |
Recently, a Trove "list" API change was made (https://bugs.launchpad.net/trove/+bug/1339400) to return IPs or hostnames. This change allows Horizon or Trove CLI to show IPs or hostnames of instances in lists with no additional calls.
So the goal of the aforementioned change was to prevent the need to additional calls. However, even with that change, an additional call can be made if hostname is not present in the instance object. This is due to the lazy loading logic in the client: if field not present, make "show" API call. With the above change merged, hostname will always be present if it is available which means that an additional API call will not return any new information. Thus, when hostname is not present, an API call should be prevented. |
|
| 2014-07-16 08:47:55 |
Nikhil Manchanda |
python-troveclient: importance |
Undecided |
Medium |
|
| 2014-07-16 08:47:59 |
Nikhil Manchanda |
python-troveclient: milestone |
|
juno-2 |
|
| 2014-08-04 22:16:11 |
Mat Lowery |
python-troveclient: status |
In Progress |
Confirmed |
|
| 2014-08-04 22:29:27 |
Mat Lowery |
description |
Recently, a Trove "list" API change was made (https://bugs.launchpad.net/trove/+bug/1339400) to return IPs or hostnames. This change allows Horizon or Trove CLI to show IPs or hostnames of instances in lists with no additional calls.
So the goal of the aforementioned change was to prevent the need to additional calls. However, even with that change, an additional call can be made if hostname is not present in the instance object. This is due to the lazy loading logic in the client: if field not present, make "show" API call. With the above change merged, hostname will always be present if it is available which means that an additional API call will not return any new information. Thus, when hostname is not present, an API call should be prevented. |
Recently, a Trove "list" API change was made (https://bugs.launchpad.net/trove/+bug/1339400) to return IPs or hostnames. That change allows Horizon or Trove CLI to show IPs or hostnames of instances in lists with no additional calls.
With the above change merged, exactly one of hostname or IP will always be present in the list of instances. However, a call per row is still possible in Horizon today if hostname is not present (but IP is). This is because Horizon checks for hostname first and since hostname is not present, it lazy-loads each instance which causes the slow rendering of Trove instances in Horizon.
One proposal is to allow clients of python-troveclient to disable lazy-loading of returned resources. Then Horizon would set the flag to disable lazy-loading when calling instances.list(). |
|
