python-swiftclient

request() got an unexpected keyword argument 'config'

Bug #1116740 reported by Jonathan Harker
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Medium
Jonathan Harker
python-keystoneclient 0.2.3
python-swiftclient
New
Undecided
Unassigned

Bug Description

requests.request() >= v1.0.0 does not accept the keyword argument 'config', but the pip requirements allows for versions up to v1.1.0. When using requests==1.0.4 the following exception is raised:

File "build/bdist.linux-x86_64/egg/swiftclient/client.py", line 328, in get_auth
  File "build/bdist.linux-x86_64/egg/swiftclient/client.py", line 265, in get_keystoneclient_2_0
swiftclient.client.ClientException: Authorization Failure. Authorization Failed: request() got an unexpected keyword argument 'config'

Tags: dependency
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21258

Changed in python-keystoneclient:
assignee: nobody → Jonathan Harker (jesusaurus)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/21258
Committed: http://github.com/openstack/python-keystoneclient/commit/a564b88e688282a16fcb27b71004576468bf1cf0
Submitter: Jenkins
Branch: master

commit a564b88e688282a16fcb27b71004576468bf1cf0
Author: K Jonathan Harker <email address hidden>
Date: Tue Feb 5 14:59:49 2013 -0800

    Pin requests module more strictly.

    requests.request() does not accept the keyword argument 'config'
    (used on keystoneclient/client.py:339) after version 1.0.0.

    Fixes bug #1116740

    Change-Id: I0a778849ff44a76a2647aa46057fdb35401fae5f

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Revision history for this message
Jay Buffington (jaybuff) wrote :

The fix to this bug introduces a new bug:

Keystone's test-requires has a version of requests that is in direct conflict with the version that is set in keystoneclient's pip-requires in commit a564b88e6

[keystone] $ git describe
grizzly-2-74-g8ec247b

[keystone] $ cat tools/test-requires |grep requests
requests>=1.0.0 # replaces httplib2 in keystoneclient >=0.2.1

Since python-keystoneclient is required by the keystone test-requires you can't satisfy all dependencies to be able to run the tests. I'd like to see this change reverted in favor of a better solution being worked on in https://review.openstack.org/#/c/21313/

Revision history for this message
Jay Buffington (jaybuff) wrote :

Sorry, I believe my previous comment was barking up the wrong tree. The problem is that a5b7fcf5f96a42bb4ac8110894b5cc146c552ad9 was committed to keystone before https://review.openstack.org/#/c/20127/ was merged into keystoneclient.

The commit related to this bug (a564b88e6) correctly reflects the fact that keystoneclient doesn't currently work with requests<1.1.

Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.2.3
status: Fix Committed → Fix Released
importance: Undecided → Medium
Revision history for this message
Pete Zaitcev (zaitcev) wrote :

This is fixed now, right?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.