python-novaclient

nova boot does not support multiple --nic parameters

Series pike
Bug #1706597

Bug #1706597 reported by Laurent Chiarello on 2017-07-26

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	python-novaclient	Fix Released	Critical	huangtianhua
	Pike	Fix Committed	High	Matt Riedemann

Bug Description

Trying to boot a server while specifying multiple --nic parameters leads to an error using latest nova client (9.0.1):

$ nova boot --flavor s1-2 --image master --nic net-name=network1 --nic net-name=network2 master2

ERROR (CommandError): Invalid nic argument 'net-name=network2'. Nic arguments must be of the form --nic <net-id=net-uuid,net-name=network-name,v4-fixed-ip=ip-addr,v6-fixed-ip=ip-addr,port-id=port-uuid>, with only one of net-id, net-name or port-id specified.

The above command works just fine when using a single --nic parameter.

This seems to be a regression from previous clients: tracked down the issue to novaclient/v2/shell.py where the commit 4b886334 moved the definition of "nic_info" outside of a loop (not sure if it can be moved back inside without other side effects).

huangtianhua (huangtianhua) on 2017-08-09

Changed in python-novaclient:
assignee:	nobody → huangtianhua (huangtianhua)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-09: Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/492003

Changed in python-novaclient:
status:	New → In Progress

Revision history for this message

Alex Xu (xuhj) wrote on 2017-08-21:

It was broken by this patch https://review.openstack.org/#/c/429512/13/novaclient/v2/shell.py

Changed in python-novaclient:
importance:	Undecided → Critical

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-21: Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/492003
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=0a3cf89c67a3fb78876137506fe57e645f4fabe4
Submitter: Jenkins
Branch: master

commit 0a3cf89c67a3fb78876137506fe57e645f4fabe4
Author: huangtianhua <email address hidden>
Date: Wed Aug 9 14:39:51 2017 +0800

Allow boot server with multiple nics

    Trying to boot a server while specifying multiple
    --nic parameters leads to an error: Invalid nic
    argument.
    This patch fixes it.

Change-Id: I662fd366df8e79db1966d45a9e090087dbace4b0
Closes-Bug: #1706597

Changed in python-novaclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-21: Fix proposed to python-novaclient (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/495901

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-27: Fix merged to python-novaclient (stable/pike)

Reviewed: https://review.openstack.org/495901
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=a1c00740c5b709a7d2bc4289fa6e28eac7909b8f
Submitter: Jenkins
Branch: stable/pike

commit a1c00740c5b709a7d2bc4289fa6e28eac7909b8f
Author: huangtianhua <email address hidden>
Date: Wed Aug 9 14:39:51 2017 +0800

Allow boot server with multiple nics

    Trying to boot a server while specifying multiple
    --nic parameters leads to an error: Invalid nic
    argument.
    This patch fixes it.

    Change-Id: I662fd366df8e79db1966d45a9e090087dbace4b0
    Closes-Bug: #1706597
    (cherry picked from commit 0a3cf89c67a3fb78876137506fe57e645f4fabe4)