python-novaclient

Incorrect help text for 'limit' option

Series newton
Bug #1645489

Bug #1645489 reported by Diana Clarke on 2016-11-28

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	python-novaclient	Fix Released	Medium	Diana Clarke
	Newton	Fix Committed	Medium	Diana Clarke

Bug Description

The keypair, hypervisor, and flavor CLIs all incorrectly say that they support a special -1 case for the 'limit' parameter. I suspect this was just copied from the servers help text by mistake.

- Maximum number of flavors to display. If limit == -1, all flavors will be displayed. If limit is bigger than 'osapi_max_limit' option of Nova API, limit 'osapi_max_limit' will be used instead.

- Maximum number of hypervisors to display. If limit == -1, all hypervisors will be displayed. If limit is bigger than 'osapi_max_limit' option of Nova API, limit 'osapi_max_limit' will be used instead.

- Maximum number of keypairs to display. If limit == -1, all keypairs will be displayed. If limit is bigger than 'osapi_max_limit' option of Nova API, limit 'osapi_max_limit' will be used instead.

Diana Clarke (diana-clarke) on 2016-11-28

Changed in python-novaclient:
assignee:	nobody → Diana Clarke (diana-clarke)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-28: Fix proposed to python-novaclient (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/403928

Changed in python-novaclient:
status:	New → In Progress

Matt Riedemann (mriedem) on 2016-11-28

Changed in python-novaclient:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-29: Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/403913
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=83106a4442c2cb2f2617576e2e5539b409130ed3
Submitter: Jenkins
Branch: master

commit 83106a4442c2cb2f2617576e2e5539b409130ed3
Author: Diana Clarke <email address hidden>
Date: Mon Nov 28 16:31:31 2016 -0500

Correct copy/paste errors in help

    The keypair, hypervisor, and flavor CLIs all incorrectly say that they
    support a special -1 case for the 'limit' parameter. I suspect this was
    just copied from the servers help text by mistake.

Change-Id: I57fb3444d54232f0718424c00c07a28b29473d19
Closes-Bug: #1645489

Changed in python-novaclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-01: Fix merged to python-novaclient (stable/newton)

Reviewed: https://review.openstack.org/403928
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=ac2a769b1f89a31eb7af28470038aa3b39c12358
Submitter: Jenkins
Branch: stable/newton

commit ac2a769b1f89a31eb7af28470038aa3b39c12358
Author: Diana Clarke <email address hidden>
Date: Mon Nov 28 16:31:31 2016 -0500

Correct copy/paste errors in help

    Change-Id: I57fb3444d54232f0718424c00c07a28b29473d19
    Closes-Bug: #1645489
    (cherry picked from commit 83106a4442c2cb2f2617576e2e5539b409130ed3)