python-novaclient

Make _discover_extensions public

Bug #1440779 reported by Andrey Kurilin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Kylin CG
OpenStack Heat 5.0.0 "liberty"
python-novaclient
Fix Released
Medium
Kylin CG
python-novaclient 2.25.0

Bug Description

Heat uses[1] `novaclient.shell.OpenStackComputeShell._discover_extensions` function[2], which is private. It means that nova developers can change interface of this method, so heat will be broken(in nova gates).
If heat wants use this method, visibility of it should be changed to public.

[1] - https://github.com/openstack/heat/tree/0a1639a5bcfd0237c988a773885b6c799b89304b/heat/engine/clients/os/nova.py#L59
[2] - https://github.com/openstack/python-novaclient/blob/3681c186f784b0b64f871050a0dfdb3b1bed37b8/novaclient/shell.py#L465

See original description
Andrey Kurilin (andreykurilin)
description: updated
Revision history for this message
Ethan Lynn (ethanlynn) wrote :

Is it better to modify novaclient and make this function public? Seems it's the only way to get extensions.

Angus Salkeld (asalkeld)
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
summary: - heat should not use private methods of novaclient
+ Make _discover_extensions public
affects: heat → python-novaclient
Kylin CG (kylin7-sg)
Changed in python-novaclient:
assignee: nobody → Kylin CG (kylin7-sg)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/171067

Changed in python-novaclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/171067
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=02c04c5658dcd968b91f7256b749755abb9d2074
Submitter: Jenkins
Branch: master

commit 02c04c5658dcd968b91f7256b749755abb9d2074
Author: kylin7-sg <email address hidden>
Date: Tue Apr 7 15:23:14 2015 +0800

    Make _discover_extensions public

    Heat uses `novaclient.shell.OpenStackComputeShell._discover_extensions`
    function, which is private currently. It's better to change this method
    to public for public use.

    Change-Id: I15879d56db2ec88a9bef99b6af8924ebd4ad169b
    Closes-bug: #1440779

Changed in python-novaclient:
status: In Progress → Fix Committed
Kylin CG (kylin7-sg)
Changed in heat:
assignee: nobody → Kylin CG (kylin7-sg)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/180812

Changed in heat:
status: New → In Progress
Matt Riedemann (mriedem)
Changed in python-novaclient:
milestone: none → 2.25.0
Matt Riedemann (mriedem)
Changed in python-novaclient:
status: Fix Committed → Fix Released
OpenStack Infra (hudson-openstack)
Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Steve Baker (steve-stevebaker)
Changed in heat:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-2 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.