python-muranoclient

murano-engine prints contents of downloaded packages to stdout

  1. Series mitaka
  2. Bug #1558702
Bug #1558702 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-muranoclient
Fix Released
Medium
Kirill Zaitsev
python-muranoclient 0.8.4
Mitaka
Fix Committed
Critical
Kirill Zaitsev
python-muranoclient 0.8.5
Newton
Fix Released
Medium
Kirill Zaitsev
python-muranoclient 0.9.0

Bug Description

To reproduce: deploy any env with and app, that has to be downloaded, and obsere engine's logs

Expected results: no binary data in logs

Kirill Zaitsev (kzaitsev)
Changed in murano:
assignee: nobody → Kirill Zaitsev (kzaitsev)
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

this is actually a bug in python-muranoclient apparently With debug-enabled it prints the contents of all the requests it makes, including downloading of the packages

Kirill Zaitsev (kzaitsev)
affects: murano → python-muranoclient
Changed in python-muranoclient:
milestone: mitaka-rc1 → none
milestone: none → 0.8.4
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/294302

Changed in python-muranoclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/294302
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=061b8ea310f4b5377b4df69064ff1d171ba46956
Submitter: Jenkins
Branch: master

commit 061b8ea310f4b5377b4df69064ff1d171ba46956
Author: Kirill Zaitsev <email address hidden>
Date: Fri Mar 18 00:56:32 2016 +0300

    Do not log contents of the download request

    keystonesession client logs contents of every request in debug mode by
    default. It makes little sense if any to log contents of a zip archive
    being downloaded.

    Change-Id: I9a7d5bda4f290e120638079fbac9e5551b7dee73
    Closes-Bug: #1558702

Changed in python-muranoclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/299691

Revision history for this message
Nikolay Starodubtsev (starodubcevna) wrote :

in real world this bug brokes deployment process.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (stable/mitaka)

Reviewed: https://review.openstack.org/299691
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=1069267fb026e867aa7767af2558b6147b4b77d1
Submitter: Jenkins
Branch: stable/mitaka

commit 1069267fb026e867aa7767af2558b6147b4b77d1
Author: Kirill Zaitsev <email address hidden>
Date: Fri Mar 18 00:56:32 2016 +0300

    Do not log contents of the download request

    keystonesession client logs contents of every request in debug mode by
    default. It makes little sense if any to log contents of a zip archive
    being downloaded.

    Change-Id: I9a7d5bda4f290e120638079fbac9e5551b7dee73
    Closes-Bug: #1558702
    (cherry picked from commit 061b8ea310f4b5377b4df69064ff1d171ba46956)

Kirill Zaitsev (kzaitsev)
tags: added: in-stable-mitaka
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-muranoclient 0.9.0

This issue was fixed in the openstack/python-muranoclient 0.9.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-muranoclient 0.8.5

This issue was fixed in the openstack/python-muranoclient 0.8.5 release.

Ekaterina Shutova (eshutova)
tags: added: on-verification
Ekaterina Shutova (eshutova)
tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.