python-mistralclient

[usability] wb/wf-validate commands' output is not friendly

Bug #1449014 reported by Anastasia Kuznetsova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-mistralclient
Triaged
Medium
Unassigned

Bug Description

CASE 1 - positive check
Steps to reproduce:
1. create file with correct workbook or workflow definition: my_file.yaml
2. execute 'mistral workbook/workflow-validate my_file.yaml'

Observer result:
Accurate table with information that everything is Ok

CASE 2 - negative check
Steps to reproduce:
1. create file with invalid workbook or workflow definition: my_file.yaml (I used https://github.com/stackforge/mistral/blob/master/mistral/tests/resources/workbook/v2/my_workbook.yaml and made a type in keyword 'tags')
2. execute 'mistral workbook/workflow-validate my_file.yaml'

Observer result:
Huge output with json scheme of workbook (take a look at attached file)

See original description
Revision history for this message
Anastasia Kuznetsova (akuznetsova) wrote :
summary: - [usability] wb/wf-validate commands output are not friendly
+ [usability] wb/wf-validate commands' output is not friendly
Revision history for this message
Anastasia Kuznetsova (akuznetsova) wrote :

I guess that bug is still actual:
venv runtests: commands[0] | mistral --version
mistral 3.0.0
Observed result: http://paste.openstack.org/show/605232/

no longer affects: python-mistralclient/liberty
description: updated
Changed in python-mistralclient:
importance: Undecided → Medium
Revision history for this message
Sharat Sharma (sharat-sharma) wrote :

Hi Anastasia,

Yes, this problem still exists and I would like to fix it. What would you think must be the output for a negative check?

Revision history for this message
Anastasia Kuznetsova (akuznetsova) wrote :

Hello Sharat,

As for me, only the first line from the error output contains helpful information,
e.g Invalid DSL: Additional properties are not allowed ('ttags' was unexpected).

It is quite hard to 'manually' parse scheme in the output and find the problem anyway,
so I suggest to cut output and show only the main error.

This is just my suggestion, the author of the feature may be disagree with me.

Revision history for this message
Sharat Sharma (sharat-sharma) wrote :

Hi Anastasia,

I find your suggestion is quite reasonable. Thanks for replying back.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.