python-manilaclient

--os-key / env[OS_KEY] not working

Bug #1999775 reported by Maurice Escher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-manilaclient
Fix Released
Undecided
Unassigned

Bug Description

Hi,

in contrast to the neighbour clients like nova and cinder I cannot specify a key next to the --os-cert option.

Workaround is to put the key into the same file like the certificate.
But for a smooth coherent experience it would be good to add this parameter.

BR,
Maurice

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/867337

Changed in python-manilaclient:
status: New → In Progress
Revision history for this message
Maurice Escher (maurice-escher) wrote :

fix is inspired by https://bugs.launchpad.net/python-cinderclient/+bug/1564646

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/867337
Committed: https://opendev.org/openstack/python-manilaclient/commit/43943fdf670328e2fe606c07949190e9e45063ae
Submitter: "Zuul (22348)"
Branch: master

commit 43943fdf670328e2fe606c07949190e9e45063ae
Author: Maurice Escher <email address hidden>
Date: Thu Dec 15 13:42:40 2022 +0100

    Support --os-key option

    keystoneclient Session expects as cert argument, one of the followings:
     * None (no client certificate),
     * a path to client certificate,
     * a tuple with client certificate/key paths.

    The change updates manilaclient code to support the last case (ie:
    os_cert and os_key are non-empty) with the --os-key option
    and OS_KEY environment variable.

    Closes-Bug: #1999775
    Change-Id: I09313b7c55a5f9d4ec032a37e69a1d79db29d648

Changed in python-manilaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/869117

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/869117
Committed: https://opendev.org/openstack/python-manilaclient/commit/8d9ea26f56b82044aa74fab669225df47143068e
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 8d9ea26f56b82044aa74fab669225df47143068e
Author: Maurice Escher <email address hidden>
Date: Thu Dec 15 13:42:40 2022 +0100

    Support --os-key option

    keystoneclient Session expects as cert argument, one of the followings:
     * None (no client certificate),
     * a path to client certificate,
     * a tuple with client certificate/key paths.

    The change updates manilaclient code to support the last case (ie:
    os_cert and os_key are non-empty) with the --os-key option
    and OS_KEY environment variable.

    Closes-Bug: #1999775
    Change-Id: I09313b7c55a5f9d4ec032a37e69a1d79db29d648
    (cherry picked from commit 43943fdf670328e2fe606c07949190e9e45063ae)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 4.3.0

This issue was fixed in the openstack/python-manilaclient 4.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/877021

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/877022

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/877023

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/877021
Committed: https://opendev.org/openstack/python-manilaclient/commit/7acf31c62b5b66899aef6c76800c2088d130da7a
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 7acf31c62b5b66899aef6c76800c2088d130da7a
Author: Maurice Escher <email address hidden>
Date: Thu Dec 15 13:42:40 2022 +0100

    Support --os-key option

    keystoneclient Session expects as cert argument, one of the followings:
     * None (no client certificate),
     * a path to client certificate,
     * a tuple with client certificate/key paths.

    The change updates manilaclient code to support the last case (ie:
    os_cert and os_key are non-empty) with the --os-key option
    and OS_KEY environment variable.

    Closes-Bug: #1999775
    Change-Id: I09313b7c55a5f9d4ec032a37e69a1d79db29d648
    (cherry picked from commit 43943fdf670328e2fe606c07949190e9e45063ae)
    (cherry picked from commit 8d9ea26f56b82044aa74fab669225df47143068e)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/877022
Committed: https://opendev.org/openstack/python-manilaclient/commit/e2a4886d7f7e1fc14d44775d662c48fed94e78a0
Submitter: "Zuul (22348)"
Branch: stable/xena

commit e2a4886d7f7e1fc14d44775d662c48fed94e78a0
Author: Maurice Escher <email address hidden>
Date: Thu Dec 15 13:42:40 2022 +0100

    Support --os-key option

    keystoneclient Session expects as cert argument, one of the followings:
     * None (no client certificate),
     * a path to client certificate,
     * a tuple with client certificate/key paths.

    The change updates manilaclient code to support the last case (ie:
    os_cert and os_key are non-empty) with the --os-key option
    and OS_KEY environment variable.

    Closes-Bug: #1999775
    Change-Id: I09313b7c55a5f9d4ec032a37e69a1d79db29d648
    (cherry picked from commit 43943fdf670328e2fe606c07949190e9e45063ae)
    (cherry picked from commit 8d9ea26f56b82044aa74fab669225df47143068e)
    (cherry picked from commit 7acf31c62b5b66899aef6c76800c2088d130da7a)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 3.3.2

This issue was fixed in the openstack/python-manilaclient 3.3.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 4.1.2

This issue was fixed in the openstack/python-manilaclient 4.1.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 3.0.3

This issue was fixed in the openstack/python-manilaclient 3.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.