python launchpad bugs is missing nomination support

Bug #172802 reported by Brian Murray
2
Affects Status Importance Assigned to Milestone
python-launchpad-bugs
Won't Fix
High
Markus Korn

Bug Description

It is possible to nominate a bug for a release of Ubuntu i.e. Gutsy and p-l-b does not have the ability to manage these nominations. This happens at a separate url like https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.22/+bug/165198/nominations/2403/+editstatus . It would be nice if this additional feature existed so the QA team could more efficiently manage nominations especially since all you can do at the nomination page is choose Accept or Decline and not add a comment at the same time.

Revision history for this message
Brian Murray (brian-murray) wrote :

This is still missing from python-launchpad-bugs.

Changed in python-launchpad-bugs:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Brian Murray (brian-murray) wrote :

Here is the html surrounding the nomination information:

  <tr class="secondary">
    <td style="padding: 0.3em 0em 0.3em 1.5em" colspan="4">
    <span class="discreet lesser" style="font-size: 100%">
      <span>Nominated</span>

      for
      <span>Intrepid</span>
      by
      <a href="/~jhasse">Jan Niklas Hasse</a>
    </span>

          (<a href="https://bugs.launchpad.net/ubuntu/+source/ubuntu-artwork/+bug/217107/nominations/4612/+editstatus"
              onclick="return toggleFormVisibility('nomination4612')">approve/decline</a>)
        <div style="display: none" id="nomination4612">
            <span style="padding-left: 1.5em">

<form action="https://bugs.launchpad.net/ubuntu/+source/ubuntu-artwork/+bug/217107/nominations/4612/+edit-form"
      method="post">
  <input type="submit" name="approve" value="Approve"
         id="approve" />
  <input type="submit" name="decline" value="Decline"
         id="decline" />
</form>

</span>
        </div>

  </td>
</tr>

Revision history for this message
Markus Korn (thekorn) wrote :

looking at it today

Changed in python-launchpad-bugs:
assignee: nobody → thekorn
status: Confirmed → In Progress
Revision history for this message
Markus Korn (thekorn) wrote :

after looking at it a bit (and trying to understand how all this nominations work) I think there needs some changes to be done. This is a small mockup explains the workflow I have in mind right now

>>> info = bug.infotable[0]
>>> info.targeted_to
None
>>> info.nomination
None
>>> info.nominate("Trunk")
>>> print info.nomination
'Nominated for Trunk by thekorn'
>>> info.targeted_to
None
>>> info.nomination.accept() #or info.nomination.decline()
>>> info.nomination
'Trunk'
>>> info.targeted_to
'Trunk'

== or ==
>>> print info.nomination
'Declined for Intrepid by thekorn'
>>> info.targeted_to
None

There is also a function like this needed:
>>> info.list_releases()
["Trunk", "0.1"]
Which lists all possible nomination targets

Implementation plan:
1.) add info.list_releases() method
2.) add info.nominate() method
3.) add info.nomination.accept() and info.nomination.decline()

Any ideas, suggestions?

Markus

Revision history for this message
Brian Murray (brian-murray) wrote :

This looks great to me. One further thing to keep in mind is that nominations can be accepted after they are declined so info.nomination.accept() should work if info.nomination is "Declined...". However, nominations can't be declined after they are accepted so that should fail before trying to commit.

Revision history for this message
Markus Korn (thekorn) wrote :

I just added my working branch, it is still not usable but I'm making good process :)

Revision history for this message
Brian Murray (brian-murray) wrote :

Maybe this should actually be won't fix since this is possible via python-launchpadlib?

Changed in python-launchpad-bugs:
status: In Progress → Triaged
Revision history for this message
Markus Korn (thekorn) wrote :

Yes, I agree it's won't fix because launchpadlib helps alot here

Changed in python-launchpad-bugs:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.