We have a try/except which catches ProtocolError. This leads to:
Couldn't construct image object
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/shade/openstackcloud.py", line 254, in _get_client
**kwargs)
File "/usr/local/lib/python2.7/dist-packages/os_client_config/cloud_config.py", line 300, in get_legacy_client
return client_class(*constructor_args, **constructor_kwargs)
File "/usr/local/lib/python2.7/dist-packages/glanceclient/client.py", line 59, in Client
module = utils.import_versioned_module(int(version), 'client')
File "/usr/local/lib/python2.7/dist-packages/glanceclient/common/utils.py", line 281, in import_versioned_module
return importutils.import_module(module)
File "/usr/local/lib/python2.7/dist-packages/oslo_utils/importutils.py", line 73, in import_module
__import__(import_str)
File "/usr/local/lib/python2.7/dist-packages/glanceclient/v2/__init__.py", line 15, in <module>
from glanceclient.v2.client import Client # noqa
File "/usr/local/lib/python2.7/dist-packages/glanceclient/v2/client.py", line 17, in <module>
from glanceclient.common import http
File "/usr/local/lib/python2.7/dist-packages/glanceclient/common/http.py", line 26, in <module>
ProtocolError = requests.packages.urllib3.exceptions.ProtocolError
AttributeError: 'module' object has no attribute 'packages'
Error fetching image list: 'module' object has no attribute 'packages'
From Ian:
I think the whole try/except block here is just wrong given the current requirement on requests (https://git.openstack.org/cgit/openstack/python-glanceclient/tree/requirements.txt#n9).
This popped up in a much older version of requests where urllib3 added the ProtocolError and then started using it and requests missed its addition and it bubbled up. There should not be any reason to continue doing this silly try/except. We should just replace the usage of ProtocolError with requests.exceptions.ConnectioneError.
https:/