Glance Client

Glance client updates tags every time even if it's not required

Bug #1587999 reported by Mike Fedosin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
In Progress
Medium
Unassigned

Bug Description

If image has tags and user wants to update it, then client tries to update its tags as well in PATCH request.

Example: http://paste.openstack.org/show/507001/

Niall Bunting (niall-bunting)
Changed in python-glanceclient:
assignee: nobody → Niall Bunting (niall-bunting)
Revision history for this message
Mike Fedosin (mfedosin) wrote :

Hi, I uploaded a fix two weeks ago https://review.openstack.org/#/c/324046/

Niall Bunting (niall-bunting)
Changed in python-glanceclient:
assignee: Niall Bunting (niall-bunting) → Mike Fedosin (mfedosin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/324046
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=e77322c17931810f4029ef339a791f702f2f4580
Submitter: Jenkins
Branch: master

commit e77322c17931810f4029ef339a791f702f2f4580
Author: Mike Fedosin <email address hidden>
Date: Wed Jun 1 21:02:29 2016 +0300

    Don't update tags every time

    This code removes unnecessary PATCH requests
    for tags updating if they were not modified.

    Change-Id: I8eced32f39d0c98e0b26014e7b2341ab6580ff01
    Closes-bug: 1587999

Changed in python-glanceclient:
status: New → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-glanceclient 2.4.0

This issue was fixed in the openstack/python-glanceclient 2.4.0 release.

Revision history for this message
Nikhil Komawar (nikhil-komawar) wrote :

https://review.openstack.org/#/c/357624/ is proposing to revert this

Revision history for this message
Nikhil Komawar (nikhil-komawar) wrote :

As a revert to this bug has been approved https://review.openstack.org/#/c/357624/ this bug goes back to open status for further digging.

The patch proposed earlier had to be reverted due to regression documented here https://bugs.launchpad.net/python-glanceclient/+bug/1614971

Please address both bugs (this) 1587999 and 1614971 in the same patch.

Changed in python-glanceclient:
status: Fix Released → Triaged
assignee: Mike Fedosin (mfedosin) → nobody
Ian Cordasco (icordasc)
Changed in python-glanceclient:
importance: Undecided → Medium
OpenStack Infra (hudson-openstack)
Changed in python-glanceclient:
status: Triaged → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.