Excess update tags

Bug #1555662 reported by Darja Shakhray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
In Progress
Medium
Mridula Joshi

Bug Description

Steps to reproduce on devstack (glance v2):
1) Create image
2) Add tags
3) Update any property (glance image-update)

Expected result:
Sending PATCH request with replace property

Actual result:
Sending PATCH request with replace property and replace all tags

For example:
1) I have image http://paste.openstack.org/show/490002/
2) glance image-update 471079b7-8a19-4fad-97ab-59c196a59234 --name name2
3) sending data '[{"path": "/name", "value": "name2", "op": "replace"}, {"path": "/tags", "value": ["tag1", "tag2"], "op": "replace"}]'

Tags: tags
Changed in python-glanceclient:
assignee: nobody → Bhargavi (challa-bhargavi1)
Bhargavi (bhargavi-c81)
Changed in python-glanceclient:
assignee: Bhargavi (challa-bhargavi1) → Bhargavi (bhargavi-c81)
Bhargavi (bhargavi-c81)
Changed in python-glanceclient:
status: New → In Progress
Bhargavi (bhargavi-c81)
Changed in python-glanceclient:
status: In Progress → Opinion
status: Opinion → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/301133

Changed in python-glanceclient:
status: Confirmed → In Progress
Bhargavi (bhargavi-c81)
Changed in python-glanceclient:
status: In Progress → Fix Released
Revision history for this message
Darja Shakhray (dshakhray) wrote :

I do not think the status of bug "fix released", because commit does not merged

Revision history for this message
Bhargavi (bhargavi-c81) wrote :

am unable to change status from "fix released" to "confirm".

Revision history for this message
Darja Shakhray (dshakhray) wrote :

I think the status "in progress", because commit on review https://review.openstack.org/#/c/301133/

Changed in python-glanceclient:
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/302003

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/302654

Revision history for this message
Anseela M M (anseela-m00) wrote :

I have created test cases for verifying the bug. Please execute these test cases once the fix is done.

Test case id: OPNST_ glance Bug:1555662 Excess update tags_1

Metric: 30 minutes

Test purpose: Verify that patch request should not send excess update tags while updating the glance image

Configuration: An OpenStack environment with at least one controller (with keystone, glance), one compute node and one network node installed.

Test tool: tempest

References: Bug_ 1555662 _ Excess update tags

Applicability: If the user trying the update any property of image, the issue exists

Pre-test conditions: Openstack should be installed and all the services up and running

Step Description:
1. create an image
2. list the images glance image-show
3. Add the tag
4. Update any property (glance image-update)
5. Check the patch request by giving –debug command
Result:
1. User should be able to create the image
2. User should be able to list the created image
3. User should be able to add the tag
4. User should be able to update the properly.
5. PATCH request should have replace property field
6. Should not contains excess tags

Test verdict: TC pass only if user can update the image and patch request contains only the replace property

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-glanceclient (master)

Change abandoned by Bhargavi (<email address hidden>) on branch: master
Review: https://review.openstack.org/301133
Reason: did not follow commit message standards.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Hemanth Makkapati (<email address hidden>) on branch: master
Review: https://review.openstack.org/302003
Reason: No recent activity, hence abandoning this. Please feel free to resurrect this when appropriate.

Revision history for this message
Brian Rosmaita (brian-rosmaita) wrote :

Resetting this bug due to no activity on associated patches so that someone else can pick it up.

Changed in python-glanceclient:
status: In Progress → Triaged
assignee: Bhargavi (bhargavi-c81) → nobody
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Brian Rosmaita (<email address hidden>) on branch: master
Review: https://review.openstack.org/302654
Reason: No activity in >1 year.

Mridula Joshi (mrjoshi)
Changed in python-glanceclient:
assignee: nobody → Mridula Joshi (mrjoshi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)
Changed in python-glanceclient:
status: Triaged → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.