python-dracclient

IndexError thrown when listing physical disks on Dell C6320

Bug #1586545 reported by Stig Telfer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-dracclient
In Progress
High
Anish Bhatt

Bug Description

I get this backtrace:

  File "/usr/lib/python2.7/site-packages/dracclient/client.py", line 327, in list_physical_disks
    return self._raid_mgmt.list_physical_disks()
  File "/usr/lib/python2.7/site-packages/dracclient/resources/raid.py", line 200, in list_physical_disks
    for disk in drac_physical_disks]
  File "/usr/lib/python2.7/site-packages/dracclient/resources/raid.py", line 218, in _parse_drac_physical_disk
    controller=fqdd.split(':')[2],
IndexError: list index out of range

Relating to this line of code:

https://github.com/openstack/python-dracclient/blob/master/dracclient/resources/raid.py#L218

It appears because a physical disk attached to the Dell C6320 RAID controller I'm using is described as:

'Disk.Bay.0:Enclosure.External.RAID.Mezzanine.1A-1'

Instead of a more typical FQDD (with two colons in it):

'Disk.Bay.7:Enclosure.Internal.0-1:RAID.Integrated.1-1'

The RAID controller on my C6320 system has ID 'RAID.Mezzanine.1A-1'

Imre Farkas (ifarkas)
Changed in python-dracclient:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Anish Bhatt (anish7) wrote :

I hit this bug recently as well and was able to make a fix. Will submit tomorrow

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-dracclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/389359

Changed in python-dracclient:
assignee: nobody → Anish Bhatt (anish7)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-dracclient (master)

Reviewed: https://review.openstack.org/389359
Committed: https://git.openstack.org/cgit/openstack/python-dracclient/commit/?id=af0894134fb210090120b3c62cbdde4a8d080939
Submitter: Jenkins
Branch: master

commit af0894134fb210090120b3c62cbdde4a8d080939
Author: Anish Bhatt <email address hidden>
Date: Thu Sep 29 14:49:34 2016 -0700

    Don't assume FQDD naming

    Splitting on fixed number of colons breaks in this case :

    Disk.Bay.0:Enclosure.Internal.0-1:RAID.Integrated.1-1
    Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1
    Disk.Bay.2:Enclosure.Internal.0-1:RAID.Integrated.1-1
    Disk.Bay.3:Enclosure.Internal.0-1:RAID.Integrated.1-1
    Disk.Direct.4:RAID.Integrated.1-1
    Disk.Direct.5:RAID.Integrated.1-1

    Split from right instead, doesn't fail

    Partial-Bug: #1586545

    Change-Id: Ib4ca517388c48ade321451cb8af07abb731e5940

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.