no way to enable meter_links on resource list via CLI

Bug #1508709 reported by Rohit Jaiswal
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-ceilometerclient
Fix Released
Undecided
Rohit Jaiswal

Bug Description

This affects stable/liberty and master.

[1] was added to liberty to enable control over generating meter_links from client. However, links is disabled by default , but there is really no way to enable that from CLI since [2] doesnt pass a value for links.

[1] https://review.openstack.org/#/c/221348/
[2] https://github.com/openstack/python-ceilometerclient/blob/stable/liberty/ceilometerclient/v2/shell.py#L1060

The resource-list shell should probably include an optional CLI argument to enable links, since currently its disabled by default.

Changed in python-ceilometerclient:
assignee: nobody → Rohit Jaiswal (rohit-jaiswal-3)
summary: - no way to enable meter_links on resource list via client
+ no way to enable meter_links on resource list via CLI
description: updated
Revision history for this message
ZhiQiang Fan (aji-zqfan) wrote :

this bug report is similar to 1508708 because they both want a switcher to control whether meter_links is enabled or not

I think in CLI, the meter_links seems not required, at least I never use it, even with debug option, the response body is very long and don't look pretty when parsing it. so I think in shell it is acceptable to disable it

for SDK, there is a switcher, so user can use it

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ceilometerclient (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/238654

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ceilometerclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/238947

Changed in python-ceilometerclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ceilometerclient (master)

Reviewed: https://review.openstack.org/238947
Committed: https://git.openstack.org/cgit/openstack/python-ceilometerclient/commit/?id=e4a62a20b1d072969e842c38b2885a46a20fc54c
Submitter: Jenkins
Branch: master

commit e4a62a20b1d072969e842c38b2885a46a20fc54c
Author: Rohit Jaiswal <email address hidden>
Date: Fri Oct 23 14:46:23 2015 +0000

    Fix to enable meter-links on resource-list CLI

    This adds an optional param to resource-list
    CLI to enable meter-links. By default, meter
    links are not generated, this patch adds an
    optional param to generate links.

    Change-Id: I308b94c8a57833cf30b4815ecec2ff9a50e91af6
    Closes-Bug: #1508709

Changed in python-ceilometerclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ceilometerclient (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/239007

Changed in python-ceilometerclient:
milestone: none → 2.0.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ceilometerclient (stable/liberty)

Reviewed: https://review.openstack.org/239007
Committed: https://git.openstack.org/cgit/openstack/python-ceilometerclient/commit/?id=b84806d87c08b7773243f8c06d1ab8773f906c43
Submitter: Jenkins
Branch: stable/liberty

commit b84806d87c08b7773243f8c06d1ab8773f906c43
Author: Rohit Jaiswal <email address hidden>
Date: Fri Oct 23 14:46:23 2015 +0000

    Fix to enable meter-links on resource-list CLI

    This adds an optional param to resource-list
    CLI to enable meter-links. By default, meter
    links are not generated, this patch adds an
    optional param to generate links.

    Change-Id: I308b94c8a57833cf30b4815ecec2ff9a50e91af6
    Closes-Bug: #1508709
    (cherry picked from commit e4a62a20b1d072969e842c38b2885a46a20fc54c)

tags: added: in-stable-liberty
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-ceilometerclient 1.5.1

This issue was fixed in the openstack/python-ceilometerclient 1.5.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.