Cancel button in preferences dialog doesn't undo the changes
Bug #619283 reported by
Tony Martínez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| PyRoom |
Fix Committed
|
Undecided
|
Unassigned | ||
Bug Description
There is no implementation in function "kill_preferences" (preferences.py) to reverse the changes if a user clicks on cancel button, so cancel button only closes the preferences dialog. If a user can modify the preferences and see the changes at the same time, I think cancel button could be dropped because the user will reverse the changes if he's not conform with them.
Related branches
Revision history for this message
| Tony Martínez (tonini500) wrote | #1 |
Revision history for this message
| Adam Rooke (abelianr) wrote | #2 |
| Changed in pyroom: | |
| status: | New → Fix Committed |
To post a comment you must log in.
Applied your fix to trunk. Behaviour before was pretty illogical and wrong. Short of rewriting the preferences mechanism this is the easiest way to "Fix" this bug.