Must complain if charm hooks aren't executable
Bug #864164 reported by
Gustavo Niemeyer
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-core |
Fix Released
|
Medium
|
Dimiter Naydenov | ||
| pyjuju |
Triaged
|
Low
|
Unassigned | ||
Bug Description
Juju is bundling charms that will knowingly break because the executable flag in the charm are not set.
It should either fix the flags by itself, or at least refuse to go ahead.
Related branches
lp://staging/~dimitern/juju-core/bug-864164-executable-hooks
- The Go Language Gophers: Pending requested
-
Diff: 436 lines (+196/-5)27 files modified.bzrignore (+1/-0)
charm/bundle.go (+14/-2)
charm/bundle_test.go (+66/-0)
charm/dir.go (+12/-2)
charm/dir_test.go (+53/-0)
charm/meta.go (+1/-1)
testing/repo/series/all-hooks/hooks/bar-relation-broken (+2/-0)
testing/repo/series/all-hooks/hooks/bar-relation-changed (+2/-0)
testing/repo/series/all-hooks/hooks/bar-relation-departed (+2/-0)
testing/repo/series/all-hooks/hooks/bar-relation-joined (+2/-0)
testing/repo/series/all-hooks/hooks/config-changed (+2/-0)
testing/repo/series/all-hooks/hooks/foo-relation-broken (+2/-0)
testing/repo/series/all-hooks/hooks/foo-relation-changed (+2/-0)
testing/repo/series/all-hooks/hooks/foo-relation-departed (+2/-0)
testing/repo/series/all-hooks/hooks/foo-relation-joined (+2/-0)
testing/repo/series/all-hooks/hooks/install (+2/-0)
testing/repo/series/all-hooks/hooks/otherdata (+1/-0)
testing/repo/series/all-hooks/hooks/self-relation-broken (+2/-0)
testing/repo/series/all-hooks/hooks/self-relation-changed (+2/-0)
testing/repo/series/all-hooks/hooks/self-relation-departed (+2/-0)
testing/repo/series/all-hooks/hooks/self-relation-joined (+2/-0)
testing/repo/series/all-hooks/hooks/start (+2/-0)
testing/repo/series/all-hooks/hooks/stop (+2/-0)
testing/repo/series/all-hooks/hooks/subdir/stuff (+1/-0)
testing/repo/series/all-hooks/hooks/upgrade-charm (+2/-0)
testing/repo/series/all-hooks/metadata.yaml (+12/-0)
testing/repo/series/all-hooks/revision (+1/-0)
| Changed in juju: | |
| assignee: | nobody → Gustavo Niemeyer (niemeyer) |
Revision history for this message
| Kapil Thangavelu (hazmat) wrote | #1 |
| Changed in juju: | |
| milestone: | none → florence |
| Changed in juju: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in juju: | |
| assignee: | Gustavo Niemeyer (niemeyer) → nobody |
| Changed in juju: | |
| milestone: | florence → galapagos |
| Changed in juju: | |
| milestone: | galapagos → honolulu |
| Changed in juju: | |
| milestone: | 0.6 → none |
| Changed in juju-core: | |
| assignee: | nobody → Dave Cheney (dave-cheney) |
| importance: | Undecided → Medium |
| Changed in juju-core: | |
| milestone: | none → 1.9.4 |
Revision history for this message
| Kapil Thangavelu (hazmat) wrote Re: [Bug 864164] Re: Must complain if charm hooks aren't executable | #2 |
| Changed in juju-core: | |
| milestone: | 1.9.4 → 1.9.5 |
| Changed in juju-core: | |
| milestone: | 1.9.5 → 1.9.6 |
| Changed in juju-core: | |
| assignee: | Dave Cheney (dave-cheney) → nobody |
| milestone: | 1.9.6 → none |
| status: | New → Triaged |
| Changed in juju-core: | |
| assignee: | nobody → Dimiter Naydenov (dimitern) |
| status: | Triaged → In Progress |
Revision history for this message
| Dimiter Naydenov (dimitern) wrote | #3 |
| Changed in juju-core: | |
| milestone: | none → 2.0 |
Revision history for this message
| Dimiter Naydenov (dimitern) wrote | #4 |
| Changed in juju-core: | |
| status: | In Progress → Fix Committed |
| Changed in juju-core: | |
| milestone: | 2.0 → 1.9.12 |
| Changed in juju-core: | |
| status: | Fix Committed → Fix Released |
| Changed in juju: | |
| importance: | Medium → Low |
To post a comment you must log in.
People are dropping random bits in the hook directory, so the hook validation routines used by debug-hooks is probably the best for the enumeration and executable check.