puppet-manila

manila::network::standalone defines parameters in a wrong section

Bug #1965548 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-manila
Fix Released
Critical
Takashi Kajinami

Bug Description

The following change added support for network_plugin_ipvN_enabled.
 https://review.opendev.org/c/openstack/puppet-manila/+/516449

However the change in the standalone class was wrong and it added parameters to the DEFAULT section.

This results in the following problems.
 - The class can't be declared with manila::network::neutron
 - Only a single instance of manila::network::standalone can be created

Takashi Kajinami (kajinamit)
Changed in puppet-manila:
importance: Undecided → Critical
assignee: nobody → Takashi Kajinami (kajinamit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-manila/+/834328

Changed in puppet-manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-manila (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-manila/+/834328
Committed: https://opendev.org/openstack/puppet-manila/commit/b903e954ede6e2f6ca72923e67a9f8821bab4225
Submitter: "Zuul (22348)"
Branch: master

commit b903e954ede6e2f6ca72923e67a9f8821bab4225
Author: Takashi Kajinami <email address hidden>
Date: Sat Mar 19 00:09:10 2022 +0900

    Fix the wrong section used to configure standalone network plugin

    This change fixes the wrong section used by manila::network::standalone
    to define the network_plugin_ipvN_enabled parameters.
    Previously this usage resulted in duplicate resource declaration, and
    made this resource type unusable.

    This change also replaces usage of undef by $::os_service_default.
    These two are effectively same but $::os_service_default is now
    globally used.

    Closes-Bug: #1965548
    Change-Id: Iedd0805ed815f0507d8fe7b7c91afdb5dfc320be

Changed in puppet-manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-manila (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-manila/+/834944

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-manila (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-manila/+/834945

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-manila (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/puppet-manila/+/834944
Committed: https://opendev.org/openstack/puppet-manila/commit/55bb672cb16616e327ee7834666976a04d05aafd
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 55bb672cb16616e327ee7834666976a04d05aafd
Author: Takashi Kajinami <email address hidden>
Date: Sat Mar 19 00:09:10 2022 +0900

    Fix the wrong section used to configure standalone network plugin

    This change fixes the wrong section used by manila::network::standalone
    to define the network_plugin_ipvN_enabled parameters.
    Previously this usage resulted in duplicate resource declaration, and
    made this resource type unusable.

    This change also replaces usage of undef by $::os_service_default.
    These two are effectively same but $::os_service_default is now
    globally used.

    Closes-Bug: #1965548
    Change-Id: Iedd0805ed815f0507d8fe7b7c91afdb5dfc320be
    (cherry picked from commit b903e954ede6e2f6ca72923e67a9f8821bab4225)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-manila (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-manila/+/834945
Committed: https://opendev.org/openstack/puppet-manila/commit/3fadcaaee9c10facf38d3a30267878aaab534a73
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 3fadcaaee9c10facf38d3a30267878aaab534a73
Author: Takashi Kajinami <email address hidden>
Date: Sat Mar 19 00:09:10 2022 +0900

    Fix the wrong section used to configure standalone network plugin

    This change fixes the wrong section used by manila::network::standalone
    to define the network_plugin_ipvN_enabled parameters.
    Previously this usage resulted in duplicate resource declaration, and
    made this resource type unusable.

    This change also replaces usage of undef by $::os_service_default.
    These two are effectively same but $::os_service_default is now
    globally used.

    Closes-Bug: #1965548
    Change-Id: Iedd0805ed815f0507d8fe7b7c91afdb5dfc320be
    (cherry picked from commit b903e954ede6e2f6ca72923e67a9f8821bab4225)
    (cherry picked from commit 55bb672cb16616e327ee7834666976a04d05aafd)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-manila (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/puppet-manila/+/835144

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-manila (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/puppet-manila/+/835254

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-manila (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/puppet-manila/+/835255

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-manila (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/puppet-manila/+/835144
Committed: https://opendev.org/openstack/puppet-manila/commit/d5cbf5c1d89323eb287c47ad9213139af1d66a9a
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit d5cbf5c1d89323eb287c47ad9213139af1d66a9a
Author: Takashi Kajinami <email address hidden>
Date: Sat Mar 19 00:09:10 2022 +0900

    Fix the wrong section used to configure standalone network plugin

    This change fixes the wrong section used by manila::network::standalone
    to define the network_plugin_ipvN_enabled parameters.
    Previously this usage resulted in duplicate resource declaration, and
    made this resource type unusable.

    This change also replaces usage of undef by $::os_service_default.
    These two are effectively same but $::os_service_default is now
    globally used.

    Closes-Bug: #1965548
    Change-Id: Iedd0805ed815f0507d8fe7b7c91afdb5dfc320be
    (cherry picked from commit b903e954ede6e2f6ca72923e67a9f8821bab4225)
    (cherry picked from commit 55bb672cb16616e327ee7834666976a04d05aafd)
    (cherry picked from commit 3fadcaaee9c10facf38d3a30267878aaab534a73)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-manila (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/puppet-manila/+/835254
Committed: https://opendev.org/openstack/puppet-manila/commit/7deaf777352fc5022806442a9026fc6165d26590
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 7deaf777352fc5022806442a9026fc6165d26590
Author: Takashi Kajinami <email address hidden>
Date: Sat Mar 19 00:09:10 2022 +0900

    Fix the wrong section used to configure standalone network plugin

    This change fixes the wrong section used by manila::network::standalone
    to define the network_plugin_ipvN_enabled parameters.
    Previously this usage resulted in duplicate resource declaration, and
    made this resource type unusable.

    This change also replaces usage of undef by $::os_service_default.
    These two are effectively same but $::os_service_default is now
    globally used.

    (victoria to ussuri)
    Conflicts:
            manifests/network/standalone.pp

    Closes-Bug: #1965548
    Change-Id: Iedd0805ed815f0507d8fe7b7c91afdb5dfc320be
    (cherry picked from commit b903e954ede6e2f6ca72923e67a9f8821bab4225)
    (cherry picked from commit 55bb672cb16616e327ee7834666976a04d05aafd)
    (cherry picked from commit 3fadcaaee9c10facf38d3a30267878aaab534a73)
    (cherry picked from commit d5cbf5c1d89323eb287c47ad9213139af1d66a9a)

tags: added: in-stable-ussuri
tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-manila (stable/train)

Reviewed: https://review.opendev.org/c/openstack/puppet-manila/+/835255
Committed: https://opendev.org/openstack/puppet-manila/commit/a215cd9465e7c40af1778a8409ff9bfc4818f39b
Submitter: "Zuul (22348)"
Branch: stable/train

commit a215cd9465e7c40af1778a8409ff9bfc4818f39b
Author: Takashi Kajinami <email address hidden>
Date: Sat Mar 19 00:09:10 2022 +0900

    Fix the wrong section used to configure standalone network plugin

    This change fixes the wrong section used by manila::network::standalone
    to define the network_plugin_ipvN_enabled parameters.
    Previously this usage resulted in duplicate resource declaration, and
    made this resource type unusable.

    This change also replaces usage of undef by $::os_service_default.
    These two are effectively same but $::os_service_default is now
    globally used.

    (victoria to ussuri)
    Conflicts:
            manifests/network/standalone.pp

    Closes-Bug: #1965548
    Change-Id: Iedd0805ed815f0507d8fe7b7c91afdb5dfc320be
    (cherry picked from commit b903e954ede6e2f6ca72923e67a9f8821bab4225)
    (cherry picked from commit 55bb672cb16616e327ee7834666976a04d05aafd)
    (cherry picked from commit 3fadcaaee9c10facf38d3a30267878aaab534a73)
    (cherry picked from commit d5cbf5c1d89323eb287c47ad9213139af1d66a9a)
    (cherry picked from commit 7deaf777352fc5022806442a9026fc6165d26590)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-manila 20.3.0

This issue was fixed in the openstack/puppet-manila 20.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-manila 17.5.0

This issue was fixed in the openstack/puppet-manila 17.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-manila 18.5.1

This issue was fixed in the openstack/puppet-manila 18.5.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-manila 19.5.0

This issue was fixed in the openstack/puppet-manila 19.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.