puppet-ironic

ironic::inspector::dnsmasq_log_facility has no effect when tftp is used

Bug #1968937 reported by Takashi Kajinami on 2022-04-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	puppet-ironic	Fix Released	Medium	Takashi Kajinami

Bug Description

The following change introduced the new dnsmasq_log_facility parameter to customize log facility of dnsmasq processes.
https://review.opendev.org/c/openstack/puppet-ironic/+/832879

However this change didn't update the template fle for ironic-inspector-dnsmasq with tftp enabled.
Because of that, the parameter has no effect when tftp is used, instead of http.

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-14: Fix proposed to puppet-ironic (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-ironic/+/837785

Changed in puppet-ironic:
status:	New → In Progress

Takashi Kajinami (kajinamit) on 2022-04-14

Changed in puppet-ironic:
assignee:	nobody → Takashi Kajinami (kajinamit)
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-15: Fix merged to puppet-ironic (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-ironic/+/837785
Committed: https://opendev.org/openstack/puppet-ironic/commit/98c9b5c81bb7a16f542c95c083166bc17b03f1a6
Submitter: "Zuul (22348)"
Branch: master

commit 98c9b5c81bb7a16f542c95c083166bc17b03f1a6
Author: Takashi Kajinami <email address hidden>
Date: Thu Apr 14 09:20:47 2022 +0900

Inspector: Fix missing log-facility when tftp protocol is used

Closes-Bug: #1968937
Change-Id: I4bfa487e6c982c99314112a58da61d6e53935b90

Changed in puppet-ironic:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-15: Fix proposed to puppet-ironic (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/puppet-ironic/+/838013

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-05-24: Fix merged to puppet-ironic (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/puppet-ironic/+/838013
Committed: https://opendev.org/openstack/puppet-ironic/commit/4a97b3347533424a8829a799717357cef5bf97b3
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 4a97b3347533424a8829a799717357cef5bf97b3
Author: Takashi Kajinami <email address hidden>
Date: Thu Apr 14 09:20:47 2022 +0900

Inspector: Fix missing log-facility when tftp protocol is used

    Closes-Bug: #1968937
    Change-Id: I4bfa487e6c982c99314112a58da61d6e53935b90
    (cherry picked from commit 98c9b5c81bb7a16f542c95c083166bc17b03f1a6)